Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.700.51.1.1\))
Subject: Re: Rename of varatt_external to varatt_external_oid
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: <apoD1Ulet2PtDrRV@paquier.xyz>
Date: Fri, 4 Sep 2026 08:43:37 +0800
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>,
 Tom Lane <tgl@sss.pgh.pa.us>,
 Andres Freund <andres@anarazel.de>
Content-Transfer-Encoding: quoted-printable
Message-Id: <1B63EFC9-93D5-4197-8D12-181D8F55ACA5@gmail.com>
References: <apoD1Ulet2PtDrRV@paquier.xyz>
To: Michael Paquier <michael@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/1B63EFC9-93D5-4197-8D12-181D8F55ACA5%40gmail.com>
Precedence: bulk


> On Sep 4, 2026, at 07:33, Michael Paquier <michael@paquier.xyz> wrote:
>=20
> Hi all,
> (Tom and Andres in CC, as they've commented on the original "round 1"
> thread)
>=20
> In order to add support of 8-byte TOAST values, one item that I have
> on my list of items is a set of renames in the varatt.h definitions
> for some objects, as of:
> - varatt_external -> varatt_external_oid
> - VARTAG_ONDISK -> VARTAG_ONDISK_OID
> - TOAST_POINTER_SIZE -> TOAST_OID_POINTER_SIZE
> - TOAST_MAX_CHUNK_SIZE -> TOAST_OID_MAX_CHUNK_SIZE
> - Few macros in varatt.h.
> - (I'm aware of the control file bit, left out on purpose as its
> tracking is still valid even if we extend to 8 bytes.)
>=20
> This is related to the following, larger patch set, but I wanted to
> make a last call before proceeding as it is hidden in a much larger
> set of patches:
> =
https://www.postgresql.org/message-id/flat/af19kUjwjhaoUTLn@paquier.xyz
>=20
> Tom has commented about this part of the patch here, presented in
> 0003:
> https://www.postgresql.org/message-id/1891064.1754681536@sss.pgh.pa.us
>=20
> This is a more ambitious version of it, with more mechanical renames
> to make the difference between the OID and OID8 flavors of the
> pointers.
>=20
> One point of the renames is to make extension folks aware of the fact
> that the new TOAST structures may need handling due to the new 8-byte
> values.  Still, I also feel guilty to not provide a set of
> compatibility definitions, which is of course one option.  Note that
> I'm planning to do all that early in the release cycle for v20, to get
> room for it.
>=20
> Rebased on HEAD is the patch I have for staging.  Any thoughts,
> comments or objections?
> --
> Michael
> <0001-Rename-varatt_external-to-varatt_external_oid.patch>

I tried to review this patch, but =E2=80=9Cgit am=E2=80=9D failed on the =
current HEAD (2b3d11aaed8). Would you please rebase?
```
% git am =
~/Downloads/0001-Rename-varatt_external-to-varatt_external_oid.patch
Applying: Rename varatt_external to varatt_external_oid
error: patch failed: src/backend/access/heap/heaptoast.c:634
error: src/backend/access/heap/heaptoast.c: patch does not apply
error: patch failed: contrib/amcheck/verify_heapam.c:1558
error: contrib/amcheck/verify_heapam.c: patch does not apply
Patch failed at 0001 Rename varatt_external to varatt_external_oid
hint: Use 'git am --show-current-patch=3Ddiff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am =
--abort".
hint: Disable this message with "git config set advice.mergeConflict =
false"
```

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/