From: Chao Li <li.evan.chao@gmail.com>
Content-Type: text/plain;
	charset=utf-8
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\))
Subject: Re: Trivial Fix: use palloc_array/repalloc_array for BufFile file
 arrays
Date: Thu, 25 Dec 2025 11:34:48 +0800
References: 
 <CAEoWx2m1Vo97Jg9=K7JAZ0xdkg5D=GkgOxZR1=EW7mUfy008fw@mail.gmail.com>
To: Postgres hackers <pgsql-hackers@lists.postgresql.org>
In-Reply-To: 
 <CAEoWx2m1Vo97Jg9=K7JAZ0xdkg5D=GkgOxZR1=EW7mUfy008fw@mail.gmail.com>
Message-Id: <1D199FA4-C146-493B-B29A-A1BF1084DBBC@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/1D199FA4-C146-493B-B29A-A1BF1084DBBC%40gmail.com>
Precedence: bulk


> On Dec 25, 2025, at 11:12, Chao Li <li.evan.chao@gmail.com> wrote:
>=20
> Hi Hackers,
>=20
> I noticed this error while working on [1].
>=20
> In BufFile, the fields is claimed as an array:
> ```
> struct BufFile
> {
>     File *files; /* palloc'd array with numFiles entries */
> ```
>=20
> However, it=E2=80=99s allocated by palloc_object():
> ```
> file->files =3D palloc_object(File);
> ```
>=20
> And reallocated by repalloc():
> ```
>     file->files =3D (File *) repalloc(file->files,
>         (file->numFiles + 1) * sizeof(File));
> ```
>=20
> This trivial patch just changes to use palloc_array/repalloc_array, =
which makes the intent clearer.
>=20
> Best regards,
> --
> Chao Li (Evan)
> HighGo Software Co., Ltd.
> https://www.highgo.com/
>=20
>=20
>=20
>=20
> <v1-0001-Use-palloc_array-repalloc_array-for-BufFile-file-.patch>


Sorry for missing the reference of [1]:

[1] https://postgr.es/m/aUStrqoOCDRFAq1M@paquier.xyz

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/