Feedback-ID: ie0a040ee:Fastmail
Message-ID: <1a0bad5f-0ab1-46bc-a70b-9290291c9cd8@eisentraut.org>
Date: Fri, 28 Mar 2025 17:32:47 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: On non-Windows, hard depend on uselocale(3)
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Thomas Munro <thomas.munro@gmail.com>,
 Michael Paquier <michael@paquier.xyz>, Andrew Dunstan <andrew@dunslane.net>,
 Tristan Partin <tristan@neon.tech>, Tom Lane <tgl@sss.pgh.pa.us>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
References: 
 <CA+hUKG+Yv+ps=nS2T8SS1UDU=iySHSr4sGHYiYGkPTpZx6Ooww@mail.gmail.com>
 <CA+hUKGKOuA4vTkFk01RSLqyM0pzNjYm-3h2zAtW48Ffc7FjjNg@mail.gmail.com>
 <CA+hUKG+ue0KC5KSqMuL5zi7uCSuXCLP_B+sZSq5=yS84606ZsA@mail.gmail.com>
 <423491f5-2eaa-454e-8dc9-037d69c1a8f9@eisentraut.org>
 <CA+hUKG+fApBC7Ziq2HP6K-6ymD=AafyvYQq9HGfyRCoBw-PGtQ@mail.gmail.com>
 <d9e7731c-ca1b-477c-9298-fa51e135574a@eisentraut.org>
 <CA+hUKGLbEhVb029AQJDCZ4+QgcqVmERJGZefxS=+b+SBBSGW8A@mail.gmail.com>
 <2652c576-29b3-4b4a-b61b-10275cacadcb@eisentraut.org>
 <CA+hUKG+iJtpun-sFqRYgJQt7eWEZnrsG_i=d_PRyHBqGrahCQw@mail.gmail.com>
 <Z0PICeukFeEutR83@paquier.xyz>
 <CA+hUKGK1J_jsS1bgRTWW9swuGYMrt8pijYAr4VUjcih7Hhqx-w@mail.gmail.com>
 <679e8c35-0429-478e-8805-607d15b82e53@eisentraut.org>
 <CA+hUKGLMpy4sXaVduYDoNWtynm5NS4f=k7M51qg4SPHzUkdxvw@mail.gmail.com>
 <b8b34a1c-1210-4998-8340-274bc73f3bad@eisentraut.org>
 <3f16f601-6785-4751-9fd9-2bfd5117e760@eisentraut.org>
 <CAD21AoBO71nQE5eR_MxA+CjzjrvUUsmeauDPJbrEF7D7dfHqBQ@mail.gmail.com>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: 
 <CAD21AoBO71nQE5eR_MxA+CjzjrvUUsmeauDPJbrEF7D7dfHqBQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/1a0bad5f-0ab1-46bc-a70b-9290291c9cd8%40eisentraut.org>
Precedence: bulk

On 28.03.25 17:14, Masahiko Sawada wrote:
> On Fri, Mar 28, 2025 at 8:30 AM Peter Eisentraut <peter@eisentraut.org> wrote:
>>
>> On 09.02.25 08:32, Peter Eisentraut wrote:
>>> Checking the status of this thread ...
>>>
>>> The patches that removed the configure checks for _configthreadlocale(),
>>> and related cleanup, have been committed.
>>>
>>> The original patch to "Tidy up locale thread safety in ECPG library" is
>>> still outstanding.
>>>
>>> Attached is a rebased version, based on the posted v6, with a couple of
>>> small fixups from me.
>>>
>>> I haven't re-reviewed it yet, but from scanning the discussion, it looks
>>> close to done.
>>
>> After staring at this a few more times, I figured it was ready enough
>> and I committed it.
> 
> It seems that some bf animals such as jackdaw are unhappy with this
> commit[0][1]. I also got the same 'undefined reference to symbol
> error' locally when building test_json_parser.

Yeah, looks like we'll have to revert this for now.  But I'm confused, 
because I don't see any clear pattern for which platforms or 
configurations it's failing and for which not.