Feedback-ID: i0c21471d:Fastmail
MIME-Version: 1.0
Date: Wed, 06 Aug 2025 14:54:13 -0300
From: "Euler Taveira" <euler@eulerto.com>
To: "Nathan Bossart" <nathandbossart@gmail.com>
Cc: "Jacob Champion" <jacob.champion@enterprisedb.com>,
 =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>,
 "Dave Cramer" <davecramer@gmail.com>,
 "PostgreSQL Hackers" <pgsql-hackers@lists.postgresql.org>
Message-Id: <1a1b279e-69d7-4609-924e-8d52f1201ef0@app.fastmail.com>
In-Reply-To: <aJLLc1JHMEcvU9mj@nathan>
References: 
 <CADK3HHLs-8fTiYikJBU45bkMYABVifkYPQU9s3vwO4EUcuOo=w@mail.gmail.com>
 <202508041231.myxuzx2udlze@alvherre.pgsql> <aJEQUTYLkS836qu5@nathan>
 <CAOYmi+nQ75D+OcyDa0cH3q5Hh_vioErtDgXHMaNGK4xfeG2EPA@mail.gmail.com>
 <aJEk695hVaEc4ve3@nathan> <aJJidMu-E-qD9hrG@nathan>
 <797cad77-647b-42c4-89b8-fd5bf8a8fd10@app.fastmail.com>
 <aJLLc1JHMEcvU9mj@nathan>
Subject: Re: More protocol.h replacements this time into walsender.c
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/1a1b279e-69d7-4609-924e-8d52f1201ef0%40app.fastmail.com>
Precedence: bulk

On Wed, Aug 6, 2025, at 12:26 AM, Nathan Bossart wrote:
> Okay, I think I've addressed all the latest feedback in v5.
>

LGTM.

I tried to apply your patch and it says

$ git am -3 v5-0001-Expand-usage-of-protocol-characters.patch
Applying: Expand usage of protocol characters.
Warning: commit message did not conform to UTF-8.
You may want to amend it after fixing the message, or set the config
variable i18n.commitEncoding to the encoding your project uses.

It seems your file is ISO-8859-1 but your commit message claims to be UTF-8.


-- 
Euler Taveira
EDB   https://www.enterprisedb.com/