Message-ID: <1a3a2f2e-9705-45ee-a2c8-6fd15b53ad67@enterprisedb.com>
Date: Thu, 18 Apr 2024 11:39:22 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: BitmapHeapScan streaming read user and prelim refactoring
To: Michael Paquier <michael@paquier.xyz>,
 Melanie Plageman <melanieplageman@gmail.com>
Cc: Thomas Munro <thomas.munro@gmail.com>,
 Heikki Linnakangas <hlinnaka@iki.fi>, Andres Freund <andres@anarazel.de>,
 Pg Hackers <pgsql-hackers@postgresql.org>,
 Nazir Bilal Yavuz <byavuz81@gmail.com>
References: <20240406134011.hjo3e2336sgcghfp@liskov>
 <4636ce5a-082b-447d-9b62-4953fc18f1af@enterprisedb.com>
 <20240406160423.r2zcjex3dngnztx4@liskov>
 <20240406213450.fatgalewqkbez4tg@liskov>
 <b4832d98-6e30-4be1-99f7-7243fe15bd18@enterprisedb.com>
 <20240407041734.74jwo5wjmxs6p5du@liskov>
 <2df2fd33-20f1-41ce-951b-6fc94ff9acb7@enterprisedb.com>
 <CAAKRu_Zg8Bj66OZD46Jd-ksh02OGrPR8z0JLPQqEZNEHASi6uw@mail.gmail.com>
 <aa3e7e5d-a452-4df0-b928-d9765b2d7088@enterprisedb.com>
 <CAAKRu_bTXNe16j=mFASOBrkzD=uvfUUqqOwE1FDsT7YvA1P=Pg@mail.gmail.com>
 <ZiDHZUmm6xP8RQ8o@paquier.xyz>
Content-Language: en-US
From: Tomas Vondra <tomas.vondra@enterprisedb.com>
In-Reply-To: <ZiDHZUmm6xP8RQ8o@paquier.xyz>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/1a3a2f2e-9705-45ee-a2c8-6fd15b53ad67%40enterprisedb.com>
Precedence: bulk

On 4/18/24 09:10, Michael Paquier wrote:
> On Sun, Apr 07, 2024 at 10:54:56AM -0400, Melanie Plageman wrote:
>> I've added an open item [1], because what's one open item when you can
>> have two? (me)
> 
> And this is still an open item as of today.  What's the plan to move
> forward here?

AFAIK the plan is to replace the asserts with actually resetting the
rs_empty_tuples_pending field to 0, as suggested by Melanie a week ago.
I assume she was busy with the post-freeze AM reworks last week, so this
was on a back burner.


regards

-- 
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company