Message-ID: <1b327a0634514f39590703831c355aa64f894e65.camel@cybertec.at>
Subject: Re: System views for versions reporting
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, jian he <jian.universality@gmail.com>, Joe
 Conway <mail@joeconway.com>, pgsql-hackers@postgresql.org
Date: Thu, 27 Nov 2025 15:27:21 +0100
In-Reply-To: <hxoniue6zwezas2bnch63bljylhueixabqhshvot4lfbsecxjx@xa4udo2x4hmq>
References: 
	<burlbnmi2a2mxt33migp3m3pqglgtat3axak2prmhiwhwuljxv@7ea4hlniydvk>
	 <866452.1742768493@sss.pgh.pa.us>
	 <yewkpc65y5g6fjd3kge2jetge3q2625hz64mietmyoczhqkmpu@ltotskxk4ndk>
	 <vyejydf4qnamuyz4slawjqzuhl3kgzfzgrtruwiuse2v6xitaa@ejvkxapdvqh5>
	 <a7d6f24f338149a0abfe058d7f5be5bbf4a7cd67.camel@cybertec.at>
	 <jx5ozoohe653lf2f7p4j65b76pikqymdunpopjkeznfdzwgokv@bt43jrh226ee>
	 <xzbehdw5d7caffbvwfjhrmmqigmrha2qx7krshoivbr7dgcjd6@5enodmbfc5sz>
	 <d7d0315b35a5f71660b1b40fa1f5c3194d78dad8.camel@cybertec.at>
	 <gpniobijngfa4ibmsqe6ts3plfn7b7mzvzriiglak73x5elw4e@3ohzphiznekv>
	 <93754df439f9bb467fb5ee75e1113358f8295f91.camel@cybertec.at>
	 <hxoniue6zwezas2bnch63bljylhueixabqhshvot4lfbsecxjx@xa4udo2x4hmq>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.56.2 (3.56.2-2.fc42) 
MIME-Version: 1.0
Archived-At: 
 <https://www.postgresql.org/message-id/1b327a0634514f39590703831c355aa64f894e65.camel%40cybertec.at>
Precedence: bulk

Thanks, the patch looks good now.

There is one tiny thing that I noticed only now, sorry:

> --- a/src/backend/utils/misc/Makefile
> +++ b/src/backend/utils/misc/Makefile
> @@ -32,7 +32,8 @@ OBJS =3D \
>     stack_depth.o \
>     superuser.o \
>     timeout.o \
> -   tzparser.o
> +   tzparser.o \
> +   system_version.o

That looks like an alphabetically sorted list too, so you should preserve
that ordering.

Anyway, I'll set this patch "ready for committer".

I am not sure if this reduced form (no report on zstd, lz4, openssl,
zlib etc.) is good enough for release, but I'll leave that decision to a co=
mmitter.

Yours,
Laurenz Albe