Message-ID: <1b50102876dc9564049c985cff0ec1903cc8d502.camel@j-davis.com>
Subject: Re: Should io_method=worker remain the default?
From: Jeff Davis <pgsql@j-davis.com>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org
Date: Fri, 05 Sep 2025 16:07:09 -0700
In-Reply-To: <a81f2f7ef34afc24a89c613671ea017e3651329c.camel@j-davis.com>
References: <d68e2a4f8c356107e5167408ad80eaa2fac0f57d.camel@j-davis.com>
	 <adywrhdn5zcfeldzug2pkzbdxizactr46goh4doiztvexrqomy@lgvl26gui63a>
	 <a81f2f7ef34afc24a89c613671ea017e3651329c.camel@j-davis.com>
Content-Type: multipart/mixed; boundary="=-4yhfhPE8zwn4QIqG4/5c"
User-Agent: Evolution 3.52.3-0ubuntu1 
MIME-Version: 1.0
Archived-At: 
 <https://www.postgresql.org/message-id/1b50102876dc9564049c985cff0ec1903cc8d502.camel%40j-davis.com>
Precedence: bulk

--=-4yhfhPE8zwn4QIqG4/5c
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 2025-09-05 at 13:25 -0700, Jeff Davis wrote:
> As an aside, I'm building with meson using -Dc_args=3D"-msse4.2 -Wtype-
> limits -Werror=3Dmissing-braces". But I notice that the meson build
> doesn't seem to use -funroll-loops or -ftree-vectorize when building
> checksums.c. Is that intentional? If not, perhaps slower checksum
> calculations explain my results.

Attached a patch. I'm not sure if it's the right way to do things, but
the resulting compiler command seems right to me.

It doesn't affect my tests in this thread much, but it seems best to be
consistent with autoconf.

Regards,
	Jeff Davis


--=-4yhfhPE8zwn4QIqG4/5c
Content-Disposition: attachment;
	filename*0=v1-0001-meson-build-checksums-with-extra-optimization-fla.pat;
	filename*1=ch
Content-Type: text/x-patch;
	name="v1-0001-meson-build-checksums-with-extra-optimization-fla.patch";
	charset="UTF-8"
Content-Transfer-Encoding: base64

RnJvbSBkNzE0ZTkzYWE3ZDI0OTNlMzk0NjU5MTQyYmJkM2YzNzhhYTBmMDUwIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBKZWZmIERhdmlzIDxqZWZmQGotZGF2aXMuY29tPgpEYXRlOiBG
cmksIDUgU2VwIDIwMjUgMTU6NDE6MzUgLTA3MDAKU3ViamVjdDogW1BBVENIIHYxXSBtZXNvbjog
YnVpbGQgY2hlY2tzdW1zIHdpdGggZXh0cmEgb3B0aW1pemF0aW9uIGZsYWdzLgoKVXNlIC1mdW5y
b2xsLWxvb3BzIGFuZCAtZnRyZWUtdmVjdG9yaXplIHdoZW4gYnVpbGRpbmcgY2hlY2tzdW0uYyB0
bwptYXRjaCB3aGF0IGF1dG9jb25mIGRvZXMuCgpEaXNjdXNzaW9uOiBodHRwczovL3Bvc3Rnci5l
cy9tL2E4MWYyZjdlZjM0YWZjMjRhODljNjEzNjcxZWEwMTdlMzY1MTMyOWMuY2FtZWxAai1kYXZp
cy5jb20KLS0tCiBzcmMvYmFja2VuZC9zdG9yYWdlL3BhZ2UvbWVzb24uYnVpbGQgfCAxMCArKysr
KysrKystCiAxIGZpbGUgY2hhbmdlZCwgOSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpk
aWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvc3RvcmFnZS9wYWdlL21lc29uLmJ1aWxkIGIvc3JjL2Jh
Y2tlbmQvc3RvcmFnZS9wYWdlL21lc29uLmJ1aWxkCmluZGV4IGMzZTRhODA1ODYyLi4xMTJmMDBm
ZjM2NSAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvc3RvcmFnZS9wYWdlL21lc29uLmJ1aWxkCisr
KyBiL3NyYy9iYWNrZW5kL3N0b3JhZ2UvcGFnZS9tZXNvbi5idWlsZApAQCAtMSw3ICsxLDE1IEBA
CiAjIENvcHlyaWdodCAoYykgMjAyMi0yMDI1LCBQb3N0Z3JlU1FMIEdsb2JhbCBEZXZlbG9wbWVu
dCBHcm91cAogCitjaGVja3N1bV9iYWNrZW5kX2xpYiA9IHN0YXRpY19saWJyYXJ5KCdjaGVja3N1
bV9iYWNrZW5kX2xpYicsCisgICdjaGVja3N1bS5jJywKKyAgZGVwZW5kZW5jaWVzOiBiYWNrZW5k
X2J1aWxkX2RlcHMsCisgIGt3YXJnczogaW50ZXJuYWxfbGliX2FyZ3MsCisgIGNfYXJnczogdmVj
dG9yaXplX2NmbGFncyArIHVucm9sbF9sb29wc19jZmxhZ3MsCispCisKK2JhY2tlbmRfbGlua193
aXRoICs9IGNoZWNrc3VtX2JhY2tlbmRfbGliCisKIGJhY2tlbmRfc291cmNlcyArPSBmaWxlcygK
ICAgJ2J1ZnBhZ2UuYycsCi0gICdjaGVja3N1bS5jJywKICAgJ2l0ZW1wdHIuYycsCiApCi0tIAoy
LjQzLjAKCg==


--=-4yhfhPE8zwn4QIqG4/5c--