Message-ID: <1b8b2841-a99c-75ca-10fb-73f2ed883013@enterprisedb.com>
Date: Thu, 27 Jan 2022 20:33:46 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Subject: Re: Bug in ProcArrayApplyRecoveryInfo for snapshots crossing 4B,
 breaking replicas
Content-Language: en-US
To: Michael Paquier <michael@paquier.xyz>
Cc: "Bossart, Nathan" <bossartn@amazon.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <36b8a501-5d73-277c-4972-f58a4dce088a@enterprisedb.com>
 <A890C641-2858-40EA-8B9A-D50EAA2EBD44@amazon.com>
 <35291484-f007-52c5-18a6-80c345f5c2ed@enterprisedb.com>
 <Ye9tn5imsHLLuLmK@paquier.xyz>
 <90de4d28-f3a3-c71c-c458-a8deef6af410@enterprisedb.com>
 <YfHRHWLhSvzRh2OH@paquier.xyz>
From: Tomas Vondra <tomas.vondra@enterprisedb.com>
In-Reply-To: <YfHRHWLhSvzRh2OH@paquier.xyz>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/1b8b2841-a99c-75ca-10fb-73f2ed883013%40enterprisedb.com>
Precedence: bulk

On 1/26/22 23:54, Michael Paquier wrote:
> On Wed, Jan 26, 2022 at 07:31:00PM +0100, Tomas Vondra wrote:
>> I actually tried doing that, but I was not very happy with the result. The
>> test has to call pg_resetwal, but then it also has to fake pg_xact data and
>> so on, which seemed a bit ugly so did not include the test in the patch.
> 
> Indeed, the dependency to /dev/zero is not good either.  The patch
> logic looks good to me.

OK, I've pushed the patch. We may consider adding a TAP test later, if 
we find a reasonably clean approach.


regards

-- 
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company