Message-ID: <1b92140d-ff31-21cb-3c06-e155471b87ac@postgrespro.ru>
Date: Tue, 11 Jul 2023 13:44:39 +0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.13.0
Subject: Re: Generating code for query jumbling through gen_node_support.pl
Content-Language: en-US
To: Michael Paquier <michael@paquier.xyz>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
 Postgres hackers <pgsql-hackers@lists.postgresql.org>,
 "Drouvot, Bertrand" <bdrouvot@amazon.com>,
 "Jonathan S. Katz" <jkatz@postgresql.org>
References: <Y8oaA5Vxnr4rzEDJ@paquier.xyz>
 <e4d61d52-4992-d190-b5ad-48c6c752942c@enterprisedb.com>
 <Y8tdmPlzFyNcrPR3@paquier.xyz>
 <bf604c8d-b6e9-284b-327a-cac8417a74e8@enterprisedb.com>
 <Y8+BdCOjxykre5es@paquier.xyz>
 <9695f035-0f2b-92b9-deed-0b7e5bb7e4e0@enterprisedb.com>
 <Y9M+C2obzgRnXPNd@paquier.xyz>
 <268fd337-8bb7-92e6-0da2-416c022c11f3@enterprisedb.com>
 <ZKyHv2qN2jrZMaWO@paquier.xyz>
 <5bcbf926-3d5a-e953-79a6-b6ab0f8b23a0@postgrespro.ru>
 <ZKzqO9wXJRe0FW5P@paquier.xyz>
From: Andrey Lepikhov <a.lepikhov@postgrespro.ru>
Organization: Postgres Professional
In-Reply-To: <ZKzqO9wXJRe0FW5P@paquier.xyz>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/1b92140d-ff31-21cb-3c06-e155471b87ac%40postgrespro.ru>
Precedence: bulk

On 11/7/2023 12:35, Michael Paquier wrote:
> On Tue, Jul 11, 2023 at 12:29:29PM +0700, Andrey Lepikhov wrote:
>> I vote for only one method based on a query tree structure.
> 
> Noted
> 
>> BTW, did you think about different algorithms of queryId generation?
> 
> Not really, except if you are referring to the possibility of being
> able to handle differently different portions of the nodes depending
> on a context given by the callers willing to do a query jumbling
> computation.  (For example, choose to *not* silence the Const nodes,
> etc.)
Yes, I have two requests on different queryId algorithms:
1. With suppressed Const nodes.
2. With replacement of Oids with full names - to give a chance to see 
the same queryId at different instances for the same query.

It is quite trivial to implement, but not easy in support.
> 
>> Auto-generated queryId code can open a way for extensions to have
>> easy-supporting custom queryIds.
> 
> Extensions can control that at some extent, already.
> --
> Michael

-- 
regards,
Andrey Lepikhov
Postgres Professional