Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1phliO-0002PJ-3s for pgsql-hackers@arkaria.postgresql.org; Thu, 30 Mar 2023 06:24:52 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1phliM-0002ls-3f for pgsql-hackers@arkaria.postgresql.org; Thu, 30 Mar 2023 06:24:50 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1phliL-0002gD-4S for pgsql-hackers@lists.postgresql.org; Thu, 30 Mar 2023 06:24:49 +0000 Received: from wnew2-smtp.messagingengine.com ([64.147.123.27]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1phliE-0005Y7-Qo for pgsql-hackers@postgresql.org; Thu, 30 Mar 2023 06:24:46 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailnew.west.internal (Postfix) with ESMTP id A80C82B0602A for ; Thu, 30 Mar 2023 02:24:38 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 30 Mar 2023 02:24:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1680157478; x=1680164678; bh=sV0evPCkjoqqej0Y9ovlwtXDZD1A2we94fu mC/bPV2s=; b=TPI/TOzqXfdN3lxxpCG2VLLVsYzR1uzloxZReh/U7y41cQeKpGA 88+b6A+3KXYpQtTaIP8LL8OiOJgTN3hVN0GcVULrekkm6szTAKHVeuoLMQ/UtFQh 1EoavfJEDyaN/j13cE7ZR+/Div+kdjBPD/yibVSGYbl37+8vreCM4j3z7SYGbcAx A6v2PfEgMgQa2JQii44CRj4d0jzPRV+kjl+eAb7DSpEBuaE7LgYkHkiPLwQzVQ1t oArcaXw6xU6KiWpwZqnDFs1FSByyQN7EAiSp/pePnYSt/AOmpKr8Bw4DMvNI9RaM 9guoh1gxIgyh7Gn8E2N8NegNVJW0tdtkg1w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdehjedguddtjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurheptgfkffggfgfhuffvsehmtderre dtfeejnecuhfhrohhmpefrvghtvghrucfgihhsvghnthhrrghuthcuoehpvghtvghrrdgv ihhsvghnthhrrghuthesvghnthgvrhhprhhishgvuggsrdgtohhmqeenucggtffrrghtth gvrhhnpeetveeuvdeikeeigefhveffhffhvdejveelleefieekieekvdffgeetkedutdef leenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehpvg htvghrrdgvihhsvghnthhrrghuthesvghnthgvrhhprhhishgvuggsrdgtohhm X-ME-Proxy: Feedback-ID: i131946ab:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Thu, 30 Mar 2023 02:24:37 -0400 (EDT) Content-Type: multipart/mixed; boundary="------------guEzNdNVz00VJAbKF8bkH57q" Message-ID: <1bf15c7a-0acd-1864-081e-7a28814310fe@enterprisedb.com> Date: Thu, 30 Mar 2023 08:24:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Content-Language: en-US From: Peter Eisentraut Subject: pg_basebackup: Correct type of WalSegSz To: pgsql-hackers List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------guEzNdNVz00VJAbKF8bkH57q Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit The pg_basebackup code has WalSegSz as uint32, whereas the rest of the code has it as int. This seems confusing, and using the extra range wouldn't actually work. This was in the original commit (fc49e24fa6), but I suppose it was an oversight. --------------guEzNdNVz00VJAbKF8bkH57q Content-Type: text/plain; charset=UTF-8; name="0001-pg_basebackup-Correct-type-of-WalSegSz.patch" Content-Disposition: attachment; filename="0001-pg_basebackup-Correct-type-of-WalSegSz.patch" Content-Transfer-Encoding: base64 RnJvbSA0M2M2YjAzYjBkMmNjMDQ0OTg5ZGU3NzIyYjhmZDdiMTM2ZmRlZDdiIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBFaXNlbnRyYXV0IDxwZXRlckBlaXNlbnRy YXV0Lm9yZz4KRGF0ZTogVGh1LCAzMCBNYXIgMjAyMyAwODoxOTowNCArMDIwMApTdWJqZWN0 OiBbUEFUQ0hdIHBnX2Jhc2ViYWNrdXA6IENvcnJlY3QgdHlwZSBvZiBXYWxTZWdTegoKVGhl IHBnX2Jhc2ViYWNrdXAgY29kZSBoYWQgV2FsU2VnU3ogYXMgdWludDMyLCB3aGVyZWFzIHRo ZSByZXN0IG9mIHRoZQpjb2RlIGhhcyBpdCBhcyBpbnQuICBUaGlzIHNlZW1zIGNvbmZ1c2lu ZywgYW5kIHVzaW5nIHRoZSBleHRyYSByYW5nZQp3b3VsZG4ndCBhY3R1YWxseSB3b3JrLgot LS0KIHNyYy9iaW4vcGdfYmFzZWJhY2t1cC9zdHJlYW11dGlsLmMgfCAyICstCiBzcmMvYmlu L3BnX2Jhc2ViYWNrdXAvc3RyZWFtdXRpbC5oIHwgMiArLQogMiBmaWxlcyBjaGFuZ2VkLCAy IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2Jpbi9w Z19iYXNlYmFja3VwL3N0cmVhbXV0aWwuYyBiL3NyYy9iaW4vcGdfYmFzZWJhY2t1cC9zdHJl YW11dGlsLmMKaW5kZXggZTc2MThmNDYxNy4uMTU1MTQ1OTljNCAxMDA2NDQKLS0tIGEvc3Jj L2Jpbi9wZ19iYXNlYmFja3VwL3N0cmVhbXV0aWwuYworKysgYi9zcmMvYmluL3BnX2Jhc2Vi YWNrdXAvc3RyZWFtdXRpbC5jCkBAIC0zMSw3ICszMSw3IEBACiAKICNkZWZpbmUgRVJSQ09E RV9EVVBMSUNBVEVfT0JKRUNUICAiNDI3MTAiCiAKLXVpbnQzMgkJV2FsU2VnU3o7CitpbnQJ CQlXYWxTZWdTejsKIAogc3RhdGljIGJvb2wgUmV0cmlldmVEYXRhRGlyQ3JlYXRlUGVybShQ R2Nvbm4gKmNvbm4pOwogCmRpZmYgLS1naXQgYS9zcmMvYmluL3BnX2Jhc2ViYWNrdXAvc3Ry ZWFtdXRpbC5oIGIvc3JjL2Jpbi9wZ19iYXNlYmFja3VwL3N0cmVhbXV0aWwuaAppbmRleCAw NGNlYjMwOTcxLi4yNjhjMTYzMjEzIDEwMDY0NAotLS0gYS9zcmMvYmluL3BnX2Jhc2ViYWNr dXAvc3RyZWFtdXRpbC5oCisrKyBiL3NyYy9iaW4vcGdfYmFzZWJhY2t1cC9zdHJlYW11dGls LmgKQEAgLTI0LDcgKzI0LDcgQEAgZXh0ZXJuIGNoYXIgKmRidXNlcjsKIGV4dGVybiBjaGFy ICpkYnBvcnQ7CiBleHRlcm4gY2hhciAqZGJuYW1lOwogZXh0ZXJuIGludAlkYmdldHBhc3N3 b3JkOwotZXh0ZXJuIHVpbnQzMiBXYWxTZWdTejsKK2V4dGVybiBpbnQJV2FsU2VnU3o7CiAK IC8qIENvbm5lY3Rpb24ga2VwdCBnbG9iYWwgc28gd2UgY2FuIGRpc2Nvbm5lY3QgZWFzaWx5 ICovCiBleHRlcm4gUEdjb25uICpjb25uOwotLSAKMi40MC4wCgo= --------------guEzNdNVz00VJAbKF8bkH57q--