Content-Type: multipart/mixed; boundary="------------EAivmM0uoKvOmzfVTOiyJEq0"
Message-ID: <1bf875d6-43ed-83bd-62df-5355207b329e@gmail.com>
Date: Wed, 29 Mar 2023 07:44:20 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.9.0
Subject: Re: Reconcile stats in find_tabstat_entry() and get rid of
 PgStat_BackendFunctionEntry
To: Michael Paquier <michael@paquier.xyz>,
 Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: melanieplageman@gmail.com, andres@anarazel.de,
 pgsql-hackers@lists.postgresql.org
References: <ZCJ53/VggExTFoO+@paquier.xyz>
 <32cd9a82-9221-f081-87d4-1f4fa6359a4d@gmail.com>
 <ZCKGROQ/W2wgZQtD@paquier.xyz>
 <20230328.174326.1226788895063455868.horikyota.ntt@gmail.com>
 <ZCOBzgZoDXfaodIB@paquier.xyz>
Content-Language: en-US
From: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
In-Reply-To: <ZCOBzgZoDXfaodIB@paquier.xyz>
Archived-At: <https://www.postgresql.org/message-id/1bf875d6-43ed-83bd-62df-5355207b329e%40gmail.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------EAivmM0uoKvOmzfVTOiyJEq0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 3/29/23 2:09 AM, Michael Paquier wrote:
> On Tue, Mar 28, 2023 at 05:43:26PM +0900, Kyotaro Horiguchi wrote:
>> No. Fine by me, except that "block read requests" seems to suggest
>> kernel read() calls, maybe because it's not clear whether "block"
>> refers to our buffer blocks or file blocks to me.. If it is generally
>> clear, I'm fine with the proposal.
> 
> Okay.  Would somebody like to draft a patch?

Please find a draft attached.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
--------------EAivmM0uoKvOmzfVTOiyJEq0
Content-Type: text/plain; charset=UTF-8;
 name="v3-0001-pg_stat_get_xact_blocks_fetched-and_hit-doc.patch"
Content-Disposition: attachment;
 filename*0="v3-0001-pg_stat_get_xact_blocks_fetched-and_hit-doc.patch"
Content-Transfer-Encoding: base64

ZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9tb25pdG9yaW5nLnNnbWwgYi9kb2Mvc3JjL3Nn
bWwvbW9uaXRvcmluZy5zZ21sCmluZGV4IGM4MDlmZjFiYTQuLmFlNWQ5YTAyMjYgMTAwNjQ0
Ci0tLSBhL2RvYy9zcmMvc2dtbC9tb25pdG9yaW5nLnNnbWwKKysrIGIvZG9jL3NyYy9zZ21s
L21vbml0b3Jpbmcuc2dtbApAQCAtNTcyNCw4ICs1NzI0LDEwIEBAIFNFTEVDVCBwaWQsIHdh
aXRfZXZlbnRfdHlwZSwgd2FpdF9ldmVudCBGUk9NIHBnX3N0YXRfYWN0aXZpdHkgV0hFUkUg
d2FpdF9ldmVudCBpCiAgICAgICAgIDxyZXR1cm52YWx1ZT5iaWdpbnQ8L3JldHVybnZhbHVl
PgogICAgICAgIDwvcGFyYT4KICAgICAgICA8cGFyYT4KLSAgICAgICAgUmV0dXJucyB0aGUg
bnVtYmVyIG9mIGJ1ZmZlcnMgZmV0Y2hlZCBmb3IgdGFibGUgb3IgaW5kZXgsIGluIHRoZSBj
dXJyZW50Ci0gICAgICAgIHRyYW5zYWN0aW9uLgorICAgICAgICBSZXR1cm5zIHRoZSBudW1i
ZXIgb2YgYmxvY2sgcmVhZCByZXF1ZXN0cyBmb3IgdGFibGUgb3IgaW5kZXgsIGluIHRoZQor
ICAgICAgICBjdXJyZW50IHRyYW5zYWN0aW9uLiBUaGlzIG51bWJlciBtaW51cyA8ZnVuY3Rp
b24+CisgICAgICAgIHBnX3N0YXRfZ2V0X3hhY3RfYmxvY2tzX2hpdDwvZnVuY3Rpb24+IGdp
dmVzIHRoZSBudW1iZXIgb2Yga2VybmVsCisgICAgICAgIDxmdW5jdGlvbj5yZWFkKCk8L2Z1
bmN0aW9uPiBjYWxscy4KICAgICAgICA8L3BhcmE+PC9lbnRyeT4KICAgICAgIDwvcm93Pgog
CkBAIC01NzM4LDggKzU3NDAsOSBAQCBTRUxFQ1QgcGlkLCB3YWl0X2V2ZW50X3R5cGUsIHdh
aXRfZXZlbnQgRlJPTSBwZ19zdGF0X2FjdGl2aXR5IFdIRVJFIHdhaXRfZXZlbnQgaQogICAg
ICAgICA8cmV0dXJudmFsdWU+YmlnaW50PC9yZXR1cm52YWx1ZT4KICAgICAgICA8L3BhcmE+
CiAgICAgICAgPHBhcmE+Ci0gICAgICAgIFJldHVybnMgdGhlIG51bWJlciBvZiBidWZmZXIg
aGl0cyBmb3IgdGFibGUgb3IgaW5kZXgsIGluIHRoZSBjdXJyZW50Ci0gICAgICAgIHRyYW5z
YWN0aW9uLgorICAgICAgICBSZXR1cm5zIHRoZSBudW1iZXIgb2YgYmxvY2sgcmVhZCByZXF1
ZXN0cyBmb3IgdGFibGUgb3IgaW5kZXgsIGluIHRoZQorICAgICAgICBjdXJyZW50IHRyYW5z
YWN0aW9uLCBmb3VuZCBpbiBjYWNoZSAobm90IHRyaWdnZXJpbmcga2VybmVsCisgICAgICAg
IDxmdW5jdGlvbj5yZWFkKCk8L2Z1bmN0aW9uPiBjYWxscykuCiAgICAgICAgPC9wYXJhPjwv
ZW50cnk+CiAgICAgICA8L3Jvdz4KIAo=

--------------EAivmM0uoKvOmzfVTOiyJEq0--