Message-ID: <1c674adf-4114-e8d8-cec7-ac10e2f424c7@enterprisedb.com>
Date: Thu, 6 Jul 2023 10:12:57 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.12.0
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Subject: Re: SQL:2011 application time
To: Daniel Gustafsson <daniel@yesql.se>,
 Paul Jungwirth <pj@illuminatedcomputing.com>
Cc: Corey Huinker <corey.huinker@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 Jaime Casanova <jcasanov@systemguards.com.ec>
References: <CA+renyUApHgSZF9-nd-a0+OPGharLQLO=mDHcY4_qQ0+noCUVg@mail.gmail.com>
 <20210911015017.GA8837@ahch-to>
 <CA+renyXZbr3c=UXzCdfihZMPhc2x6asZLfoeMjWRvDo+J2cTVQ@mail.gmail.com>
 <CADkLM=d-Qaq0wJNjV5K1jN9+CSNY1B9uXodAnM8dxwaDFxVCfQ@mail.gmail.com>
 <CA+renyXTJ_mACO=_pZ7q06qaGy3KsG60Q66HXypCGzSxM_qRkA@mail.gmail.com>
 <CADkLM=ekdXZceMyggb6Lqj2447VfiS-Bw22Gdgd5tBotfKmi6A@mail.gmail.com>
 <CA+renyUMKg4-MyVbAi8Kj12Srd9BkU5Gt3FdbGdNr-ezHpL6cw@mail.gmail.com>
 <5650d77a-1d73-fd8d-4410-8e97dbeff572@illuminatedcomputing.com>
 <CA+renyWqpNdsi9OaPmXheeQL72adi_iz36VgVsqyyGpQ20FDAg@mail.gmail.com>
 <21964319-46e5-3e47-217b-6ac4169bdf13@enterprisedb.com>
 <CA+renyX0ipvY6A_jUOHeB1q9mL4bEYfAZ5FBB7G7jUo5bykjrA@mail.gmail.com>
 <f42e5be5-cd3e-bc4f-83e4-04a1e0270b17@enterprisedb.com>
 <27361388-f5ab-ea36-ea35-41d68a90e60d@illuminatedcomputing.com>
 <152e4c2c-36b4-bdc0-1b62-e9f9e8b68adc@enterprisedb.com>
 <251B44D1-D3E0-47E4-AB9D-4A848EDB495E@yesql.se>
Content-Language: en-US
In-Reply-To: <251B44D1-D3E0-47E4-AB9D-4A848EDB495E@yesql.se>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/1c674adf-4114-e8d8-cec7-ac10e2f424c7%40enterprisedb.com>
Precedence: bulk

On 04.07.23 14:48, Daniel Gustafsson wrote:
>> On 8 May 2023, at 09:10, Peter Eisentraut <peter.eisentraut@enterprisedb.com> wrote:
>>
>> On 03.05.23 23:02, Paul Jungwirth wrote:
>>> Thank you again for the review. Here is a patch with most of your feedback addressed. Sorry it has taken so long! These patches are rebased up to 1ab763fc22adc88e5d779817e7b42b25a9dd7c9e
>>> (May 3).
>>
>> Here are a few small fixup patches to get your patch set compiling cleanly.
>>
>> Also, it looks like the patches 0002, 0003, and 0004 are not split up correctly.  0002 contains tests using the FOR PORTION OF syntax introduced in 0003, and 0003 uses the function build_period_range() from 0004.
> 
> These patches no longer apply without a new rebase.  Should this patch be
> closed in while waiting for the prequisite of adding btree_gist to core
> mentioned upthread?  I see no patch registered in the CF for this unless I'm
> missing sometihng.

I had talked to Paul about this offline a while ago.  btree_gist to core 
is no longer considered a prerequisite.  But Paul was planning to 
produce a new patch set that is arranged and sequenced a bit 
differently.  Apparently, that new version is not done yet, so it would 
make sense to either close this entry as returned with feedback, or move 
it to the next commit fest as waiting on author.