User-Agent: Cyrus-JMAP/3.5.0-alpha0-1126-g6962059b07-fm-20210901.001-g6962059b
Mime-Version: 1.0
Message-Id: <1c8ee74f-d393-42c7-b83d-dad991717a1a@www.fastmail.com>
In-Reply-To: <202109061751.3qz5xpugwx6w@alvherre.pgsql>
References: <202109061751.3qz5xpugwx6w@alvherre.pgsql>
Date: Tue, 07 Sep 2021 19:39:30 -0300
From: "Euler Taveira" <euler@eulerto.com>
To: "Alvaro Herrera" <alvherre@alvh.no-ip.org>,
 "Rahila Syed" <rahilasyed90@gmail.com>
Cc: "Amit Kapila" <amit.kapila16@gmail.com>,
 "Tomas Vondra" <tomas.vondra@enterprisedb.com>,
 "Peter Smith" <smithpb2250@gmail.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Column Filtering in Logical Replication
Content-Type: multipart/alternative;
 boundary=171460eed09e4b8da1ea8812da5ef4e9
Archived-At: 
 <https://www.postgresql.org/message-id/1c8ee74f-d393-42c7-b83d-dad991717a1a%40www.fastmail.com>
Precedence: bulk

--171460eed09e4b8da1ea8812da5ef4e9
Content-Type: text/plain

On Mon, Sep 6, 2021, at 2:51 PM, Alvaro Herrera wrote:
> I pushed the clerical part of this -- namely the addition of
> PublicationTable node and PublicationRelInfo struct.  I attach the part
> of your v4 patch that I didn't include.  It contains a couple of small
> corrections, but I didn't do anything invasive (such as pgindent)
> because that would perhaps cause you too much merge pain.
While updating the row filter patch [1] (because it also uses these
structures), I noticed that you use PublicationRelInfo as a type name instead
of PublicationRelationInfo. I choose the latter because there is already a data
structure named PublicationRelInfo (pg_dump.h). It is a client-side data
structure but I doesn't seem a good practice to duplicate data structure names
over the same code base.

[1] https://www.postgresql.org/message-id/0c2464d4-65f4-4d91-aeb2-c5584c1350f5%40www.fastmail.com


--
Euler Taveira
EDB   https://www.enterprisedb.com/

--171460eed09e4b8da1ea8812da5ef4e9
Content-Type: text/html
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE html><html><head><title></title><style type=3D"text/css">p.Mso=
Normal,p.MsoNoSpacing{margin:0}</style></head><body><div>On Mon, Sep 6, =
2021, at 2:51 PM, Alvaro Herrera wrote:<br></div><blockquote type=3D"cit=
e" id=3D"qt" style=3D""><div>I pushed the clerical part of this -- namel=
y the addition of<br></div><div>PublicationTable node and PublicationRel=
Info struct.&nbsp; I attach the part<br></div><div>of your v4 patch that=
 I didn't include.&nbsp; It contains a couple of small<br></div><div>cor=
rections, but I didn't do anything invasive (such as pgindent)<br></div>=
<div>because that would perhaps cause you too much merge pain.<br></div>=
</blockquote><div>While updating the row filter patch [1] (because it al=
so uses these<br></div><div>structures), I noticed that you use Publicat=
ionRelInfo as a type name instead<br></div><div>of PublicationRelationIn=
fo. I choose the latter because there is already a data<br></div><div>st=
ructure named PublicationRelInfo (pg_dump.h). It is a client-side data<b=
r></div><div>structure but I doesn't seem a good practice to duplicate d=
ata structure names<br></div><div>over the same code base.<br></div><div=
><br></div><div>[1] <a href=3D"https://www.postgresql.org/message-id/0c2=
464d4-65f4-4d91-aeb2-c5584c1350f5%40www.fastmail.com">https://www.postgr=
esql.org/message-id/0c2464d4-65f4-4d91-aeb2-c5584c1350f5%40www.fastmail.=
com</a><br></div><div><br></div><div><br></div><div>--<br></div><div id=3D=
"sig112409080"><div class=3D"signature">Euler Taveira<br></div><div clas=
s=3D"signature">EDB&nbsp;&nbsp; <a href=3D"https://www.enterprisedb.com/=
">https://www.enterprisedb.com/</a><br></div></div><div><br></div></body=
></html>
--171460eed09e4b8da1ea8812da5ef4e9--