Message-ID: <1cb41fed6554739b0adc04602a7f63af0ceee4f0.camel@j-davis.com>
Subject: Re: Fix search_path for all maintenance commands
From: Jeff Davis <pgsql@j-davis.com>
To: Isaac Morland <isaac.morland@gmail.com>
Cc: Nathan Bossart <nathandbossart@gmail.com>, Noah Misch
 <noah@leadboat.com>,  "David G. Johnston" <david.g.johnston@gmail.com>,
 Gurjeet Singh <gurjeet@singh.im>, pgsql-hackers@postgresql.org, Robert Haas
 <robertmhaas@gmail.com>, Greg Stark <stark@mit.edu>, Tom Lane
 <tgl@sss.pgh.pa.us>
Date: Tue, 07 Nov 2023 13:47:05 -0800
In-Reply-To: <CAMsGm5e8fBTzfXTW9eydT3oaER+0U9_0k7wh1BWnme2CuonqBw@mail.gmail.com>
References: <e44327179e5c9015c8dda67351c04da552066017.camel@j-davis.com>
	 <b701501541a424111ffe47be055e0ccefefd7745.camel@j-davis.com>
	 <2cf41c8edeaaf7acb757095e6eceab8ae926f3da.camel@j-davis.com>
	 <CABwTF4XWKqx06UxApH8pnBdp_w2iL6VEbGKxDyjCW7-FNhLCBQ@mail.gmail.com>
	 <CAKFQuwbcUv9QmrfQKRRi1aq4E68xHD9N05_VZ2TLbMpxMV9Opg@mail.gmail.com>
	 <CABwTF4W5mZ+5fJEEh2vp7trGzwn-gnG6o13hAALmLjHdpeUn2g@mail.gmail.com>
	 <CAKFQuwZmswfTKtx6oUY0N7UB62cO_nABMgQgdcvrD8r4qjvUJg@mail.gmail.com>
	 <20230715211333.GB3675150@rfd.leadboat.com>
	 <20230717175813.GA717781@nathanxps13>
	 <2ad1dd4e5be5567c0d75676b348eab33b529e974.camel@j-davis.com>
	 <a5960b98b7d8b655f46b4b69387f1290f5848ad4.camel@j-davis.com>
	 <dfdd53fcf4be43777c81bf66ef725e28b3169ce1.camel@j-davis.com>
	 <CAMsGm5e8fBTzfXTW9eydT3oaER+0U9_0k7wh1BWnme2CuonqBw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu2 
MIME-Version: 1.0
Archived-At: <https://www.postgresql.org/message-id/1cb41fed6554739b0adc04602a7f63af0ceee4f0.camel%40j-davis.com>
Precedence: bulk

On Tue, 2023-10-31 at 13:16 -0400, Isaac Morland wrote:
> Perhaps the search_path for running a maintenance command should be
> the search_path set for the table owner (ALTER ROLE =E2=80=A6 SET search_=
path
> =E2=80=A6)?

After some thought, I don't think that's the right approach. It adds
another way search path can be changed, which adds to the complexity.

Also, by default it's "$user", public; and given that "public" was
world-writable until recently, that doesn't seem like a good idea for a
change intended to prevent search_path manipulation.

Regards,
	Jeff Davis