Message-ID: <1cbb5040-a83c-4a40-87e9-45811b89a026@gmail.com>
Date: Thu, 17 Oct 2024 09:09:29 +0700
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: POC, WIP: OR-clause support for indexes
To: Alexander Korotkov <aekorotkov@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>,
 Alena Rybakina <a.rybakina@postgrespro.ru>,
 jian he <jian.universality@gmail.com>, Nikolay Shaplov <dhyan@nataraj.su>,
 pgsql-hackers@lists.postgresql.org, pgsql-hackers@postgresql.org,
 Peter Geoghegan <pg@bowt.ie>, Marcos Pegoraro <marcos@f10.com.br>,
 teodor@sigaev.ru, Peter Eisentraut <peter@eisentraut.org>,
 Ranier Vilela <ranier.vf@gmail.com>
References: <567ED6CA.2040504@sigaev.ru>
 <CAPpHfdvF864n=Lzmjd2XBi9TwboZvrhRtLSt2hCP+JVUv6XKzg@mail.gmail.com>
 <CACJufxHCJvC3X8nUK-jRvRru-ZEXp16EBPADOwTGaqmOYM1Raw@mail.gmail.com>
 <fe11e5c9-877e-4306-a6a9-122125c7d2e5@postgrespro.ru>
 <93464dd6-d484-4021-b71f-e82928bf6758@gmail.com>
 <63617a30-6078-4e86-b44b-6364e04e210d@postgrespro.ru>
 <21752e9e-26fb-4665-bfcc-090bf4093e5a@postgrespro.ru>
 <CAPpHfduBA9RXa1LQAz=wFK8cGx_AaHVK_vnNqCnG4yA7KwFf7g@mail.gmail.com>
 <9ac6480d-6686-4c3a-9149-ba66df4f88ad@gmail.com>
 <CAPpHfds4wGdWQ2xx1OUKZC4ggqS6Q=cBSck9Re1ajY0ESkwcmw@mail.gmail.com>
 <CA+TgmoZ3tQ3Zwzo+9uXQL_tf0rDHQHKeZ4bGt1LDvL+_dqghUg@mail.gmail.com>
 <CAPpHfdt8kowRDUkmOnO7_WJJQ1uk+O379JiZCk_9_Pt5AQ4+0w@mail.gmail.com>
 <CAPpHfdu9QJ=Gbua3CUUH2KKG_8urakJTen4JD47PGh9wWP=QxQ@mail.gmail.com>
 <CAPpHfds3m=55cY1ea1TRzUAgD3pgwmvqm=exVMdOM4q+YT6kHg@mail.gmail.com>
 <45050ba9-3777-4cc1-89ad-a02deebe7729@gmail.com>
 <CAPpHfdvxF1OZUoJr2bg8cmAnty-KyRkswPa3hCPSmR5gSx7-Yg@mail.gmail.com>
Content-Language: en-AU
From: Andrei Lepikhov <lepihov@gmail.com>
In-Reply-To: <CAPpHfdvxF1OZUoJr2bg8cmAnty-KyRkswPa3hCPSmR5gSx7-Yg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/1cbb5040-a83c-4a40-87e9-45811b89a026%40gmail.com>
Precedence: bulk

On 10/17/24 03:39, Alexander Korotkov wrote:
> On Wed, Oct 16, 2024 at 7:22 AM Andrei Lepikhov <lepihov@gmail.com> wrote:
>> On 10/12/24 21:25, Alexander Korotkov wrote:
>>> I forgot to specify (COSTS OFF) for EXPLAINs in regression tests.  Fixed in v42.
>> I've passed through the patch set.
>>
>> Let me put aside the v42-0003  patch—it looks debatable, and I need time
>> to analyse the change in regression tests caused by this patch.
> 
> Yes, 0003 patch is for illustration purposes for now.  I will not keep
> rebasing it.  We can pick it later when main patches are committed.
Got it. I will save it into the TODO list.
> 
>> Comments look much better according to my current language level. Ideas
>> with fast exits also look profitable and are worth an additional
>> 'matched' variable.
>>
>> So, in general, it is ok. I think only one place with
>> inner_other_clauses can be improved. Maybe it will be enough to create
>> this list only once,  outside 'foreach(j, groupedArgs)' cycle? Also, the
>> comment on the necessity of this operation was unclear to me. See the
>> attachment for my modest attempt at improving it.
> 
> Thank you, I've integrated your patch with minor edits from me.
Thanks, I'm not sure about necessity to check NIL value of a list 
(list_free also do it), but I'm ok with the edits.

-- 
regards, Andrei Lepikhov