Message-ID: <1ce1430e-1f1b-32da-b6c9-9b63153c51d9@enterprisedb.com>
Date: Tue, 18 Jan 2022 17:05:36 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.0
Subject: Re: New developer papercut - Makefile references INSTALL
Content-Language: en-US
To: Daniel Gustafsson <daniel@yesql.se>, Magnus Hagander <magnus@hagander.net>
Cc: Tim McNamara <tim@mcnamara.nz>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <730dae39-abaa-4140-893b-95d732fed003@www.fastmail.com>
 <F2F48D23-6109-474B-9D9A-95294804B488@yesql.se>
 <CABUevEw4qN0jQyWyo7w4YkJRV=F15VSE_tLTL-UcPkYAAFEZVg@mail.gmail.com>
 <4EE5D9D9-AE71-4830-8DEE-01E91565244B@yesql.se>
 <20CFEB28-9CF8-4AD8-BB7F-0E8A9EDA8BA7@yesql.se>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <20CFEB28-9CF8-4AD8-BB7F-0E8A9EDA8BA7@yesql.se>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/1ce1430e-1f1b-32da-b6c9-9b63153c51d9%40enterprisedb.com>
Precedence: bulk


On 18.01.22 16:51, Daniel Gustafsson wrote:
>> On 17 Jan 2022, at 13:26, Daniel Gustafsson <daniel@yesql.se> wrote:
>>
>>> On 17 Jan 2022, at 11:25, Magnus Hagander <magnus@hagander.net> wrote:
>>
>>> That said, I'm not sure we're actually gaining anything by *not*
>>> referring to the website as well. TBH, I bet the majority of users
>>> will actually prefer to read them there. So I'd suggest always
>>> including the reference to the website as well, per the suggestion
>>> from Tim.
>>
>> Fair point, I'll go ahead and do that in a bit unless anyone objects.
> 
> I plan on applying the attached which address the feedback given.

The indentation of the two INSTRUCTIONS= lines uses a different mix of 
tabs and spaces, so it looks a bit weird depending on how you view it.

It's also a bit strange that the single quotes are part of the value of 
$INSTRUCTIONS rather than part of the fixed text.

The URL links to the "devel" version of the installation instructions, 
which will not remain appropriate after release.  I don't know how to 
fix that without creating an additional maintenance point.  Since 
README.git already contains that link, I would leave off the web site 
business and just make the change of the dynamically chosen file name.