Message-ID: <1cec7fb9-e7ac-8523-06fd-60b25c9a7b7d@gmail.com>
Date: Tue, 14 May 2024 15:00:00 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: Avoid orphaned objects dependencies, take 3
Content-Language: en-US
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
References: <ZiZBZSgWuSC0C1RJ@ip-10-97-1-34.eu-west-3.compute.internal>
 <a0e850b9-31c6-86cd-351d-6b8a7a1d6bf7@gmail.com>
 <ZidAHRJyMzPZ5JtJ@ip-10-97-1-34.eu-west-3.compute.internal>
 <Ziff3vGRKv1LUjY7@ip-10-97-1-34.eu-west-3.compute.internal>
 <ZijE6UBCo02U2TXJ@ip-10-97-1-34.eu-west-3.compute.internal>
 <62310067-6dc4-97ab-6724-7d3602b5056d@gmail.com>
 <ZinjZmaMEEkOSfZ0@ip-10-97-1-34.eu-west-3.compute.internal>
 <403075e1-4d60-09e2-a06a-749cd9d88f66@gmail.com>
 <ZioEJafHC95wjfMk@ip-10-97-1-34.eu-west-3.compute.internal>
 <d815344e-a6a2-617a-d35f-012e5e89f29f@gmail.com>
 <Zjy/o3t/26exwj5Z@ip-10-97-1-34.eu-west-3.compute.internal>
From: Alexander Lakhin <exclusion@gmail.com>
In-Reply-To: <Zjy/o3t/26exwj5Z@ip-10-97-1-34.eu-west-3.compute.internal>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/1cec7fb9-e7ac-8523-06fd-60b25c9a7b7d%40gmail.com>
Precedence: bulk

Hi Bertrand,

09.05.2024 15:20, Bertrand Drouvot wrote:
> Oh I see, your test updates an existing dependency. v4 took care about brand new
> dependencies creation (recordMultipleDependencies()) but forgot to take care
> about changing an existing dependency (which is done in another code path:
> changeDependencyFor()).
>
> Please find attached v5 that adds:
>
> - a call to the new depLockAndCheckObject() function in changeDependencyFor().
> - a test when altering an existing dependency.
>
> With v5 applied, I don't see the issue anymore.

Me too. Thank you for the improved version!
I will test the patch in the background, but for now I see no other
issues with it.

Best regards,
Alexander