Re: When to drop src/tools/msvc support

public inbox for [email protected]  
help / color / mirror / Atom feed

From: Andrew Dunstan <[email protected]>
To: Dave Page <[email protected]>
To: Magnus Hagander <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: Alvaro Herrera <[email protected]>
Cc: Amit Kapila <[email protected]>
Cc: Jonathan S. Katz <[email protected]>
Cc: Peter Geoghegan <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: [email protected]
Subject: Re: When to drop src/tools/msvc support
Date: Tue, 11 Apr 2023 06:58:43 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <CA+OCxowwwJy4KP3+MrQVBHX5A9Ymb8W2Xt6vH_VvgUY6tiOL8Q@mail.gmail.com>
References: <[email protected]>
	<[email protected]>
	<CA+TgmobY5DO3CX_kzjyFKEYg7vTdvoFJd=Y0qLabd8K3eAdf6Q@mail.gmail.com>
	<[email protected]>
	<CA+TgmoZwJ09Aw_igiLV7J-OPikii5PyW_iJyXCFtS1MdcY7hJQ@mail.gmail.com>
	<CA+OCxoxCZ2Q4vz0oznYqDgU4aZYv0GXO4TytkD070OjUp0OJeQ@mail.gmail.com>
	<[email protected]>
	<CABUevEzX1xVDS=tV_MTNcPhJZXZSvXCZVBLp_gv=_kpPPhE-BQ@mail.gmail.com>
	<CA+OCxowwwJy4KP3+MrQVBHX5A9Ymb8W2Xt6vH_VvgUY6tiOL8Q@mail.gmail.com>


On 2023-04-11 Tu 04:05, Dave Page wrote:
>
>
> On Tue, 11 Apr 2023 at 08:09, Magnus Hagander <[email protected]> wrote:
>
>     On Tue, Apr 11, 2023 at 12:27 AM Andres Freund
>     <[email protected]> wrote:
>     >
>     > Hi,
>     >
>     > On 2023-04-10 19:55:35 +0100, Dave Page wrote:
>     > > Projects other than the EDB installers use the MSVC build
>     system - e.g.
>     > > pgAdmin uses it’s own builds of libpq and other tools (psql,
>     pg_dump etc)
>     > > that are pretty heavily baked into a fully automated build
>     system (even the
>     > > build servers and all their requirements are baked into Ansible).
>     > >
>     > > Changing that lot would be non-trivial, though certainly
>     possible, and I
>     > > suspect we’re not the only ones doing that sort of thing.
>     >
>     > Do you have a link to the code for that, if it's open? Just to
>     get an
>     > impression for how hard it'd be to switch over?
>
>
>     The pgadmin docs/readme refers to
>     https://github.com/pgadmin-org/pgadmin4/tree/master/pkg/win32
>
>     It clearly doesn't have the full automation stuff, but appears to have
>     the parts about building the postgres dependency.
>
>
> Yeah, that's essentially the manual process, though I haven't tested 
> it in a while. The Ansible stuff is not currently public. I suspect 
> (or rather, hope) that we can pull in all the additional packages 
> required using Chocolatey which shouldn't be too onerous.
>
> Probably my main concern is that the Meson build can use the same 
> version of the VC++ compiler that we use (v14), which is carefully 
> matched for compatibility with all the various components, just in 
> case anything passes CRT pointers around. Python is the one thing we 
> don't build ourselves on Windows and the process will build modules 
> like gssapi and psycopg (which links with libpq of course), so we're 
> basically following what they use.
>
>

For meson you just need to to "pip install meson ninja" in your python 
distro and you should be good to go (they will be installed in python's 
Scripts directory). Don't use chocolatey to install meson/ninja - I ran 
into issues doing that.

AFAICT meson will use whatever version of VC you have installed, 
although I have only been testing with VC2019.


cheers


andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

view thread (21+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: When to drop src/tools/msvc support
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox