Message-ID: <1d49e214-93bc-4928-945c-27e60251a6ad@uni-muenster.de>
Date: Thu, 19 Feb 2026 08:55:03 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: WIP - xmlvalidate implementation from TODO list
To: Marcos Magueta <maguetamarcos@gmail.com>
Cc: Andrey Borodin <x4mmm@yandex-team.ru>,
 Kirill Reshke <reshkekirill@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <CAN3aFCdx8AapWSVpJ1kaC7OC_v7QwbjgbGw9WfPBBY2GMyOadQ@mail.gmail.com>
 <68a012d3-121b-418a-913b-aa0aaf32915d@uni-muenster.de>
 <CAN3aFCcXwS7BrU1gHRUEBH3G59EVf_7LUhLeEWqW2Sc9Vk5k-A@mail.gmail.com>
 <CAN3aFCe_cBshj0rb7J8yoT+fRHOBOZmk-m8V7DMLDe0ZjSgjcA@mail.gmail.com>
 <ed564b19-a70b-4715-9c65-f58df03bed43@uni-muenster.de>
 <CAN3aFCc2voQ=6+Nwy99NFJZwveYmwtCKAj6U9RhjxqQc25+Q_g@mail.gmail.com>
 <2898f090-d9cf-475c-940c-a99da4a308f1@uni-muenster.de>
 <CAN3aFCcUFLbdVBoL6c2bMh4r5P9EnXM9eBsX8+ZyER7YBSDUtA@mail.gmail.com>
 <08052569-9384-41b5-bcb7-33929fcc6c71@uni-muenster.de>
 <cfd2c12a-41fb-4a8b-9b14-390e53f4c898@uni-muenster.de>
 <ccc35098-a93c-4510-abd9-71d395acdba5@uni-muenster.de>
 <CAN3aFCecpcPBs4x3KUuxTqvY2VzpCZZKrBphNaQjE5uD8UtEpQ@mail.gmail.com>
 <CAN3aFCcb0Nvap1CKShd5RNa+V+pray+ur_LtOON3nkwqdh5NMA@mail.gmail.com>
 <2ba05acc-6392-42a4-b59e-61df086b2d4d@uni-muenster.de>
 <CAN3aFCdW3_RNgidcV_vWA-NFeYf6p7M5VMG8moSzk3bBJneUxQ@mail.gmail.com>
Content-Language: de-DE, en-GB
From: Jim Jones <jim.jones@uni-muenster.de>
In-Reply-To: <CAN3aFCdW3_RNgidcV_vWA-NFeYf6p7M5VMG8moSzk3bBJneUxQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/1d49e214-93bc-4928-945c-27e60251a6ad%40uni-muenster.de>
Precedence: bulk

Hi Marcos,

Thanks for the update.

On 18/02/2026 20:20, Marcos Magueta wrote:
> Here's the v6 with the docs updated and some minor things. 

Unfortunately, the patch no longer applies.[1]

> I was trying to figure out how to do the roles, and I have some thoughts
> on it now. While I am not particularly against predefined roles, I think
> we should be careful before committing to them in this form. As
> predefined roles, they would effectively become part of a long-term
> public interface: once they exist, we should then carry them forward and
> preserve their semantics across releases, so adding a feature-specific
> role increases permanent surface area (docs, tests, upgrade behavior,
> compatibility expectations) and is harder to revisit later if the
> privilege model evolves (which I think will make people mad, it's XML
> burden after all).
> 
> Also, a write-oriented role is not as straightforward as I thought with
> the current ownership model (and that's me guessing here). Mutating DDL
> behavior is still owner-driven (or superuser-driven) most of the places,
> not purely ACL-driven, so a pg_write_xmlschemas role can look clearer at
> first glance than it is in practice. To make that role fully consistent,
> we may need broader policy decisions around what should be grantable
> versus what should remain ownership-based, not just new role entries.
> Again, I am not opposed to the idea, but these made me a bit anxious to
> simply add them. What are your thoughts on these?

The creation of XML schemas does not need to be specifically controlled
by predefined roles - it was just the first thing that came to mind. My
concern was that leaving it entirely open to any user could lead to
unwanted CPU or memory usage. Perhaps the other reviewers have a
different opinion on this.

Best, Jim

1 - https://cfbot.cputube.org/patch_6372.log