Received: from localhost (unknown [200.46.208.211]) by mail.postgresql.org (Postfix) with ESMTP id 6CE9363864D for ; Fri, 27 Mar 2009 09:20:10 -0300 (ADT) Received: from mail.postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.208.211]) (amavisd-maia, port 10024) with ESMTP id 49869-06 for ; Fri, 27 Mar 2009 09:19:48 -0300 (ADT) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-fx0-f174.google.com (mail-fx0-f174.google.com [209.85.220.174]) by mail.postgresql.org (Postfix) with ESMTP id 2468C632E5E for ; Fri, 27 Mar 2009 09:19:52 -0300 (ADT) Received: by fxm22 with SMTP id 22so1625245fxm.19 for ; Fri, 27 Mar 2009 05:19:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=wt/ExuUtwnvO1PR4BPI/J0PMXpN9WLVBbChwV1vYXfQ=; b=f7L1luHsMxcRJXqdZnZfZh1RqhO5OE+K6ol547NuaaJf1znO/VW1ZeuexaHxqJGfHa SjCTVnIZOdTtgDR7G/UpwAIGTQpv4TIsowRnRb8dLmDGNWxLv4PVOMnQ4Oai2U4tzssK hanGz1EJC/1wg1VBSphHs1kZOy+pbRZgn5PNY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=OmRxI+DHXsNEPgSZvoPE9Rcbd7eaiOmLQfVV1rFoBCfC3NRHvWZsfjPoSBxo7+tOCI EAtUH5mWhl3fVE5OOGikLiFdQDl6Or+AYPc+VR3yX5UtfyR6ZtkSck2V6tMFQ+8B6oGb g1qroGFz5qxhD9n9BejFcQSLQingQnnXVMKYg= MIME-Version: 1.0 Received: by 10.223.109.19 with SMTP id h19mr16216fap.20.1238138495921; Fri, 27 Mar 2009 00:21:35 -0700 (PDT) In-Reply-To: <3f0b79eb0903261938l15a6a8b8v5a7f8dec2c795cef@mail.gmail.com> References: <3f0b79eb0903242329j12865d55s348f5c873a956e71@mail.gmail.com> <3f0b79eb0903250144k453b3927mffa8b08678ed057b@mail.gmail.com> <1d4e0c10903250155w34bd79dcvfab2ad5c95e56011@mail.gmail.com> <49C9F255.EE98.0025.0@wicourts.gov> <1d4e0c10903250848x4e067c86ue611c0c50f25e49d@mail.gmail.com> <3f0b79eb0903251851v5936d6b4x49997ac8f04b98b9@mail.gmail.com> <1d4e0c10903260032v767da1fdg6cf7cea86c64cc45@mail.gmail.com> <1238064633.16568.420.camel@ebony.2ndQuadrant> <1d4e0c10903260454p10107c23j7ff9a3de8be09dde@mail.gmail.com> <3f0b79eb0903261938l15a6a8b8v5a7f8dec2c795cef@mail.gmail.com> Date: Fri, 27 Mar 2009 08:21:35 +0100 Message-ID: <1d4e0c10903270021s4c7bbfccxee1c8b731302988d@mail.gmail.com> Subject: Re: New trigger option of pg_standby From: Guillaume Smet To: Fujii Masao Cc: Simon Riggs , Kevin Grittner , pgsql-hackers Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0.794 tagged_above=0 required=5 tests=AWL=-0.600, DATE_IN_PAST_03_06=1.394 X-Spam-Level: X-Archive-Number: 200903/1132 X-Sequence-Number: 135810 On Fri, Mar 27, 2009 at 3:38 AM, Fujii Masao wrote: > OK, I'll change the patch as Simon suggested; removing -t and adding > two new options: -f = fast failover (existing behavior), -p patient failover. > Also I'll default the patient failover, so it's performed when the signal > (SIGINT or SIGUSR1) is received. I'm wondering if we should consider backpatching this one. Even if the feature works as advertised in the documentation. It's a very surprising behaviour and I'm pretty sure someone will shoot himself in the foot with it, if not already done. Considering backpatching might change the way we want to fix it. -- Guillaume