Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pc29V-0006jk-Mo for pgsql-hackers@arkaria.postgresql.org; Tue, 14 Mar 2023 10:45:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pc29T-0007BE-RV for pgsql-hackers@arkaria.postgresql.org; Tue, 14 Mar 2023 10:45:07 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pc29T-0007B3-Fx for pgsql-hackers@lists.postgresql.org; Tue, 14 Mar 2023 10:45:07 +0000 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pc29P-0002xe-2i for pgsql-hackers@lists.postgresql.org; Tue, 14 Mar 2023 10:45:07 +0000 Received: by mail-wm1-x334.google.com with SMTP id o5-20020a05600c510500b003ec0e4ec6deso6721466wms.3 for ; Tue, 14 Mar 2023 03:45:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=migops.com; s=google; t=1678790700; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=P78k524wevfpKodg7ktjpb3Je3C+GvLrIl1OU3ziPTw=; b=O2p9lujkZhvE4I+vGYs4u3ZjNXmXS3zMZtkPjIJHGSV/DJCLjjgccLPITSBOOTzYVb Eg+2ZR7BkaOz7V8vVFm+grzbUQk+xpnANrTiS7Dv5CP6mLlDV5YbJRkPrkXV0tgZe1WF 9oeK+rqMbFL8a+7uPADNxB6+gvbLpJbZ7OLCAtT3QI9QEYwH2igvj74xVgY8WvdV8Myq PhgOrE/NQPmYYqz/y5fnnCngTMUWyIADyLj4nq8XnG/+mCUaR6er40FcpH1J+yKMStuW t8O1sYOzTHMBXEN4LAcqfeUO44tDfXzk2X5MNy6yp5tomBX+oMA6SFpFE8jyVS86hgi8 0Cmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678790700; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=P78k524wevfpKodg7ktjpb3Je3C+GvLrIl1OU3ziPTw=; b=hLGIWBJhjOK1d3ihtYwgmveMmnfZRmfyGaws609nWJsn14MUTaJMRMFqCr62PBhDmj 8A9dUW+b6UEH5rJhZ96zOQ9mYd4073x4vkPiOgMOel8SIV2XNBPl38Zlxnj5YYvxJ26w Twddmt4/q5uCQdGwAqgIb3TnY21K6rEme5TB9nU0l2nJfjbrFepIAle7J2PcidU4wS0S CH/fPjPD0OEPUw0fRkG1+c2Lwia4Fh+dljDgA6okyhBtJ2Vz+D8Lfsk731L+dN1h/GDo qmjjAKCS1UfutL/X2fQtfLtS5YoUjhQrOKPNEzAhUyxf7OniNgjYqPm2ZgLM3qdhslay gCew== X-Gm-Message-State: AO0yUKVywFBbV4WJ3SYbsJdmypdXlHtZnldGVHtZhuDi92ewJe1yXRky 7U7CsaFTDh4SAM4e8OZ683HGCQ== X-Google-Smtp-Source: AK7set9ggw58ZD52c8R7g6M4ZdM1Tlmwp42z92wlkSpSB56HqPHZqtI+0W5PJ2qA4Rsrwyl2wE/wag== X-Received: by 2002:a05:600c:4e16:b0:3dc:4042:5c21 with SMTP id b22-20020a05600c4e1600b003dc40425c21mr13431623wmq.6.1678790700571; Tue, 14 Mar 2023 03:45:00 -0700 (PDT) Received: from ?IPV6:2a01:cb14:51d:5100:eb63:d90b:fab8:69f9? ([2a01:cb14:51d:5100:eb63:d90b:fab8:69f9]) by smtp.gmail.com with ESMTPSA id l5-20020a7bc445000000b003ed2276cd0dsm2302934wmi.38.2023.03.14.03.45.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Mar 2023 03:45:00 -0700 (PDT) Message-ID: <1d5ea320-b791-e5a5-e523-54ac8e13204f@migops.com> Date: Tue, 14 Mar 2023 11:44:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [Proposal] Allow pg_dump to include all child tables with the root table To: stephane tachoires , pgsql-hackers@lists.postgresql.org Cc: Gilles Darold References: <5aa393b5-5f67-8447-b83e-544516990ee2@migops.com> <10a19c1f-752f-99e3-b91f-143bcbfd0024@migops.com> <167878743282.628976.2716063914740820451.pgcf@coridan.postgresql.org> Content-Language: fr From: Gilles Darold In-Reply-To: <167878743282.628976.2716063914740820451.pgcf@coridan.postgresql.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Le 14/03/2023 à 10:50, stephane tachoires a écrit : > The following review has been posted through the commitfest application: > make installcheck-world: tested, passed > Implements feature: tested, passed > Spec compliant: tested, passed > Documentation: tested, passed > > V5 is ok (aside for LLVM 14 deprecated warnings, but that's another problem) with meson compile and meson test on Ubuntu 20.04.2. > Code fits well and looks standart, --help explain what it does clearly, and documentation is ok (but as a Français, I'm not an expert in English). Thanks Stepane, I've changed commit fest status to "Ready for committers". -- Gilles Darold