Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lPmCI-0002wG-1X for pgsql-hackers@arkaria.postgresql.org; Fri, 26 Mar 2021 13:08:18 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lPmCG-0006ND-Tv for pgsql-hackers@arkaria.postgresql.org; Fri, 26 Mar 2021 13:08:16 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lPmCG-0006N6-N4 for pgsql-hackers@lists.postgresql.org; Fri, 26 Mar 2021 13:08:16 +0000 Received: from mail-ed1-x530.google.com ([2a00:1450:4864:20::530]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lPmC8-00046K-In for pgsql-hackers@lists.postgresql.org; Fri, 26 Mar 2021 13:08:15 +0000 Received: by mail-ed1-x530.google.com with SMTP id w18so6307786edc.0 for ; Fri, 26 Mar 2021 06:08:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=d9N4UkQhtFOd7BxnkD/vY05qZTeEPHb7+kBE+uvepkc=; b=hKnJUhx+xC+SRCNBJRVP+f7O+SNFpqPc9owgbOJjPt9qUAbYUG9Efzxh1aMhT7wxao 11bQaKuH1bLfXasnPnH+4LX51+0ysVbgSgrYvyvfUNk8GYfptEVK1swOw9U2ibgRs81U eZVMF7QgWEjn9wF2zPtB4FnV94a2Sy24NHot0zAcRqEp69EnSAawcjeQn/jFWxJLwRF6 r17lXcYaIDV/LLFmUjAbUTyLKilUEY4G9nOz/KprJV6Yg1cBHAaVpaniInyWjh3UjwnE tWJR7VKrVpAPMbU2mv0pYkNT/KRCEw2yqRvKI9FCl6TE4NFYDh1mTZdGRwEkr4MvFBRW pw1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=d9N4UkQhtFOd7BxnkD/vY05qZTeEPHb7+kBE+uvepkc=; b=mXwLHUsY4HlNFjGrGjqIzseBtBln5IeDDpQq0VBf+0wNQNfZ9J3HBevSQ+UImLNAGU LpQ62sIP5rafyEXn805B6bZMvzLwYtB04ffZsYfibZGzpmS8qVXj19FXGadyG9eHbQwY Qxcgcnr83tSzP6Dulw+MmgNWKhRceliCvM+nYh5EdAnQdSOfJaQ69Ob7KGLktxNYnAk4 7Vk6tTQWSiZ6Cgq6zjKJnRDqZi/Hj5OYVzks6uT4RHHbFjp4ynKhhICo7dTtkbvjqrKL Wu9dbJzYvdI5+zBTy+FhbonhgWp2zRdiPGeX00KKylrlwixS+WIsJX5EigjUiCo+HnS6 2o6A== X-Gm-Message-State: AOAM532/4B7nFSpYCXk8HhWo3BCIP16ggR6HPV/xsz6cOxXZUD979dz9 zppgRLGZNUfAYfyQSF2m4MuYECv9tS44oA3jEp46Fh2EEPJmyhISn10qn6b43LTBwbZUdjz440Y vnma2Zsgm+rz6iAB/rEXEDhm1C/mc80M4KHYn7YcT5/vOhcM4aYK5vSidCDnQ7K+hujl6AkpjLk mop6yw9iJeMa2ID6Z+1M98jdqhjcwJytRP3Y7B0emZFbJOZjGQJMJpxDot38YYvrGIbBaODCdUE gZDgMC2xHq/5FZ7j2Ix+/Rkv1aKvd7q4zKW+q8kxMTByiIs8vygfw== X-Google-Smtp-Source: ABdhPJxCkMRe8ikh+/PjPwkOIfejI1Ecl2rlzTX1h6muaAZgtvxcx6jfDfleeDCG05ge4rxdV94ebQ== X-Received: by 2002:aa7:d492:: with SMTP id b18mr14799179edr.381.1616764086852; Fri, 26 Mar 2021 06:08:06 -0700 (PDT) Received: from [10.137.0.20] (ip-86-49-253-127.net.upcbroadband.cz. [86.49.253.127]) by smtp.gmail.com with ESMTPSA id lu5sm3861316ejb.97.2021.03.26.06.08.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Mar 2021 06:08:06 -0700 (PDT) Subject: Re: WIP: BRIN multi-range indexes From: Tomas Vondra To: John Naylor Cc: Alvaro Herrera , PostgreSQL Hackers References: <20210303001725.GA1766@alvherre.pgsql> <23a0a854-8f1a-e965-7121-f76b1b2fc271@enterprisedb.com> <8e319879-32ff-1eb8-d7d3-6a3ac8a51728@enterprisedb.com> <35e866e9-d820-07de-b2be-69d5ac479179@enterprisedb.com> <71dfd257-c5ce-530d-90d3-7c744a28e97b@enterprisedb.com> <54b47e66-bd8a-d44a-2090-fd4b2f49abe6@enterprisedb.com> <357fb6d7-649f-822e-ff43-16b39aed68ee@enterprisedb.com> Message-ID: <1da94012-f512-ffc8-dd5e-888d862b662e@enterprisedb.com> Date: Fri, 26 Mar 2021 14:08:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <357fb6d7-649f-822e-ff43-16b39aed68ee@enterprisedb.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, I've pushed both the bloom and minmax-multi indexes today. Based on the feedback and limitations described before I decided to keep them in core (i.e. not move them to contrib), but it was very useful experiment as it uncovered a couple issues - both in existing code, and in the definition of the new opclasses. After further thought I've concluded that the decision to ditch the old signature (in a1c649d889) was probably wrong, so I've added the support back, per what Alexander originally proposed. While doing so, I've noticed that the NULL handling may be a few bricks shy, because with (oi_regular_nulls == false) it should probably keep passing the NULL scan keys to the consistent function. I'll look into that and get it fixed. Thanks everyone who helped with those patches! -- Tomas Vondra EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company