Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tsRst-002AF3-L5 for pgsql-hackers@arkaria.postgresql.org; Wed, 12 Mar 2025 19:36:56 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tsRsr-00Bvbe-TH for pgsql-hackers@arkaria.postgresql.org; Wed, 12 Mar 2025 19:36:53 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tsRsr-00BvbE-8E for pgsql-hackers@lists.postgresql.org; Wed, 12 Mar 2025 19:36:53 +0000 Received: from mail.postgrespro.ru ([93.174.132.70]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tsRsn-002Tzt-0Y for pgsql-hackers@postgresql.org; Wed, 12 Mar 2025 19:36:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mx2023; t=1741808204; bh=mvU1qk1FHAzNWR2HGUjCcpD4wMQYj2Agg2yl/3U77w4=; h=Message-ID:Date:User-Agent:Subject:To:Cc:References:From: In-Reply-To:From; b=EhmP9xHrgeuQ+ZKOppwiqja6G8o0rqj6+v9aH5yEFdSHLiJaWuLllBsLmtiOO3NVw TuxIIoIon9WMixOxvuNeSbme5OzqopwK188TCIOoq0MPcfqB0g0YyMRH3TVNB1OqIf FUPAdsmmSD1kLcUSETeBcpGJMrzIZ4o26ADSkZh2kNMN8T8126tbAoOQbFnrV4FtQa aqbT9wCSsw5eYdCpsG6nToVd2uxOofdTohYya8F3IreX3kNbBKXBD5EutdLNdo7fN7 u7/87NY28kEBVQvSSEIDyQLbvgOVLxaGyq/qNtRU3fb2+sZyNhlh9f72T/9UG0atIo dlLl6lzFCPCQg== Received: from [172.20.10.11] (unknown [89.113.151.81]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: a.rybakina@postgrespro.ru) by mail.postgrespro.ru (Postfix/587) with ESMTPSA id 04204608E5; Wed, 12 Mar 2025 22:36:42 +0300 (MSK) Content-Type: multipart/alternative; boundary="------------QtY03XWztEPHjWGSbh6dcgAr" Message-ID: <1dcd4262-188f-4734-9a26-1c2a5aaf3da7@postgrespro.ru> Date: Wed, 12 Mar 2025 22:36:39 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Vacuum statistics To: Kirill Reshke Cc: pgsql-hackers , Alexander Korotkov , Jim Nasby , Ilia Evdokimov , Andrei Zubkov , Masahiko Sawada , Melanie Plageman , jian he , a.lepikhov@postgrespro.ru, Sami Imseih References: <5AA8FFD5-6DE2-4A31-8E00-AE98F738F5D1@upgrade.com> <85b963fe-5977-43aa-9241-75b862abcc69@postgrespro.ru> <9C7A167C-DCDE-4A17-9ABE-6276723FEC50@upgrade.com> <2d493cf9-9ba7-4cc1-a3f2-67afd7c163ee@postgrespro.ru> <30d54302-9e9c-4e04-819e-a13b679cdcc8@postgrespro.ru> <86f76aa5-1ab5-4e2e-9b15-405051852a2a@postgrespro.ru> <1e81a0a1-a63b-48fb-905a-d6495f89ab73@postgrespro.ru> <0b4eefc7-4c38-4caa-b2ca-a4c75dd7dd12@postgrespro.ru> <333c2306-c401-4959-9f0c-a44c670a11a9@postgrespro.ru> <513f0188-b093-4cc8-98cf-4c324570d525@postgrespro.ru> Content-Language: en-US From: Alena Rybakina In-Reply-To: X-KSMG-AntiPhishing: NotDetected, bases: 2025/03/12 19:00:00 X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.1.0.7854, bases: 2025/03/12 14:00:00 #27729811 X-KSMG-AntiVirus-Status: NotDetected, skipped X-KSMG-LinksScanning: not scanned, disabled by settings X-KSMG-Message-Action: skipped X-KSMG-Rule-ID: 1 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------QtY03XWztEPHjWGSbh6dcgAr Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi! On 10.03.2025 16:33, Kirill Reshke wrote: > On Thu, 27 Feb 2025 at 23:00, Alena Rybakina wrote: >> Hi! >> On 17.02.2025 17:46, Alena Rybakina wrote: >>> On 04.02.2025 18:22, Alena Rybakina wrote: >>>> Hi! Thank you for your review! >>>> >>>> On 02.02.2025 23:43, Alexander Korotkov wrote: >>>>> On Mon, Jan 13, 2025 at 3:26 PM Alena Rybakina >>>>> wrote: >>>>>> I noticed that the cfbot is bad, the reason seems to be related to >>>>>> the lack of a parameter in >>>>>> src/backend/utils/misc/postgresql.conf.sample. I added it, it >>>>>> should help. >>>>> The patch doesn't apply cleanly. Please rebase. >>>> I rebased them. >>> The patch needed a rebase again. There is nothing new since version >>> 18, only a rebase. >> The patch needed a new rebase. >> >> Sorry, but due to feeling unwell I picked up a patch from another thread >> and squashed the patch for vacuum statistics for indexes and heaps in >> the previous version. Now I fixed everything together with the rebase. >> >> -- >> Regards, >> Alena Rybakina >> Postgres Professional > Hi! > CI fails on this one[0] > > Is it a flap or a real problem caused by v20? > > ``` > > SELECT relpages AS irp > diff -U3 /tmp/cirrus-ci-build/src/test/regress/expected/vacuum_tables_and_db_statistics.out > /tmp/cirrus-ci-build/build-32/testrun/recovery/027_stream_regress/data/results/vacuum_tables_and_db_statistics.out > --- /tmp/cirrus-ci-build/src/test/regress/expected/vacuum_tables_and_db_statistics.out > 2025-03-10 09:36:10.274799176 +0000 > +++ /tmp/cirrus-ci-build/build-32/testrun/recovery/027_stream_regress/data/results/vacuum_tables_and_db_statistics.out > 2025-03-10 09:49:35.796596462 +0000 > @@ -65,7 +65,7 @@ > WHERE vt.relname = 'vestat' AND vt.relid = c.oid; > relname | vm_new_frozen_pages | tuples_deleted | relpages | > pages_scanned | pages_removed > ---------+---------------------+----------------+----------+---------------+--------------- > - vestat | 0 | 0 | 455 | > 0 | 0 > + vestat | 0 | 0 | 417 | > 0 | 0 > (1 row) > > SELECT relpages AS rp > === EOF === > > > ``` > > [0]https://api.cirrus-ci.com/v1/artifact/task/5336493629112320/testrun/build-32/testrun/recovery/027_stream_regress/log/regress_log_027_stream_regress Thank you for your help, I'll fix it soon. -- Regards, Alena Rybakina Postgres Professional --------------QtY03XWztEPHjWGSbh6dcgAr Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Hi!

On 10.03.2025 16:33, Kirill Reshke wrote:
On Thu, 27 Feb 2025 at 23:00, Alena Rybakina <a.rybakina@postgrespro.ru> wrote:

Hi!
On 17.02.2025 17:46, Alena Rybakina wrote:

On 04.02.2025 18:22, Alena Rybakina wrote:

Hi! Thank you for your review!

On 02.02.2025 23:43, Alexander Korotkov wrote:

On Mon, Jan 13, 2025 at 3:26 PM Alena Rybakina
<a.rybakina@postgrespro.ru> wrote:

I noticed that the cfbot is bad, the reason seems to be related to
the lack of a parameter in
src/backend/utils/misc/postgresql.conf.sample. I added it, it
should help.

The patch doesn't apply cleanly.  Please rebase.

I rebased them.

The patch needed a rebase again. There is nothing new since version
18, only a rebase.

The patch needed a new rebase.

Sorry, but due to feeling unwell I picked up a patch from another thread
and squashed the patch for vacuum statistics for indexes and heaps in
the previous version. Now I fixed everything together with the rebase.

--
Regards,
Alena Rybakina
Postgres Professional

Hi!
CI fails on this one[0]

Is it a flap or a real problem caused by v20?

```

 SELECT relpages AS irp
diff -U3 /tmp/cirrus-ci-build/src/test/regress/expected/vacuum_tables_and_db_statistics.out
/tmp/cirrus-ci-build/build-32/testrun/recovery/027_stream_regress/data/results/vacuum_tables_and_db_statistics.out
--- /tmp/cirrus-ci-build/src/test/regress/expected/vacuum_tables_and_db_statistics.out
2025-03-10 09:36:10.274799176 +0000
+++ /tmp/cirrus-ci-build/build-32/testrun/recovery/027_stream_regress/data/results/vacuum_tables_and_db_statistics.out
2025-03-10 09:49:35.796596462 +0000
@@ -65,7 +65,7 @@
 WHERE vt.relname = 'vestat' AND vt.relid = c.oid;
  relname | vm_new_frozen_pages | tuples_deleted | relpages |
pages_scanned | pages_removed
 ---------+---------------------+----------------+----------+---------------+---------------
- vestat  |                   0 |              0 |      455 |
   0 |             0
+ vestat  |                   0 |              0 |      417 |
   0 |             0
 (1 row)

 SELECT relpages AS rp
=== EOF ===


```

[0] https://api.cirrus-ci.com/v1/artifact/task/5336493629112320/testrun/build-32/testrun/recovery/027_stream_regress/log/regress_log_027_stream_regress
Thank you for your help, I'll fix it soon. 
-- 
Regards,
Alena Rybakina
Postgres Professional
--------------QtY03XWztEPHjWGSbh6dcgAr--