Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1foFNO-0007Qm-Oq for pgsql-hackers@arkaria.postgresql.org; Fri, 10 Aug 2018 21:55:19 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1foFNK-0003k5-Sr for pgsql-hackers@arkaria.postgresql.org; Fri, 10 Aug 2018 21:55:14 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1foFNK-0003jv-Hv for pgsql-hackers@lists.postgresql.org; Fri, 10 Aug 2018 21:55:14 +0000 Received: from mail-qt0-x242.google.com ([2607:f8b0:400d:c0d::242]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1foFNG-0002LN-OJ for pgsql-hackers@lists.postgresql.org; Fri, 10 Aug 2018 21:55:13 +0000 Received: by mail-qt0-x242.google.com with SMTP id e19-v6so11876954qtp.8 for ; Fri, 10 Aug 2018 14:55:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=9JpGt6AV426kD0sBxbfOaF8256kOXC3RzEYgCZ5fWUc=; b=lah0K2J7mMvFKydyGTCKlyS/HXe5q37Z+/s8yodpEPWwltOOj1wz2a9ZfRIDYRNE2Q GS9ySwRyeWolbMRGxIwyr40C4V7/E3Vw5q+uoGrW6JGG558RpCB1f1XJ4DnfFXnf400U SZBeyqm2W16f1l76H5ewSpoIL3E4zcWKET9KnmNpAVEiE0iAJfdC9M0SKMVC5R48wydv DYy0TwgNZTyZGXqgGcoKuTp9S035Nl8U/UdiUUaNjRpvBUX5/FTpJbXTD/hh5mwYLvYT aSZhEEswpzWuPJbj106xXQlkhvr1AeO1JWSAiTcWH9PvJLMhmItLPIVAvX+HeZBF5l2z fGVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=9JpGt6AV426kD0sBxbfOaF8256kOXC3RzEYgCZ5fWUc=; b=KIR8Wetpx3V+bMXtfUl1y6Sh6mBTjCgY9YAo1MZfljmgIGEjvvhp6NuYuzQx2sDbKH 8y2Crzr9740Wi+1BDYE3vx1wbQ7HnTeTbRN+L3itmK+lusNJ7ilSH/FcYRIrXtzATS1y VvohQ/AzDmzyOagmsZsr2Zg1so6/SaLOkvuAqDuNxmW2+8F8hK7+1r9RVwxQoSo+zgVp ppX5/m83h+e3YUOW5Ogbot654vE5HZlVwhEYKuZAt5Fu74eBHuOnxwyroSB/rhCpGNkK 6//38Cnd371yKwL26UBptY+sljFxEHroV8xl+F8K4iBIzFjdEWVp5B/5VFY22BQUQAgM qBgQ== X-Gm-Message-State: AOUpUlEPB2AKW7IFnhRpock/3EMevtNAH20LiSvW/lKa6lOTLrVaG8Ui WMBGRV1uJTWYBHh0T2+xfoT004yMf2ThDixOuTGq+uZpTT7d8MblZM7xiIDCbhGrKE5YBop982I ktuetJ7dgTMDe+7LYeY/xN/TaSPhfohyu/9KLshfm05cyXKR15gY29AaGTslkeIwx06Rzrjv/p2 S67NfD9oI4rsmmYiGs6plU X-Google-Smtp-Source: AA+uWPyyqRrxok+HHb8+UwymgzDSr1tNajwToIAsTja4VycTbpTPTiv/ZSLtgxhNlP81CtaGHdtnhg== X-Received: by 2002:ac8:53d2:: with SMTP id c18-v6mr8116617qtq.146.1533938108407; Fri, 10 Aug 2018 14:55:08 -0700 (PDT) Received: from [192.168.10.146] ([98.122.175.38]) by smtp.gmail.com with ESMTPSA id u4-v6sm7612859qtj.12.2018.08.10.14.55.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Aug 2018 14:55:07 -0700 (PDT) From: Andrew Dunstan X-Google-Original-From: Andrew Dunstan Subject: Re: libpq compression To: Konstantin Knizhnik , Robbie Harwood , Thomas Munro Cc: Grigory Smolkin , PostgreSQL Hackers References: <429cf55b-a8bf-c4ba-196d-5b45420145a1@postgrespro.ru> <36db5d02-45e6-b863-1418-825ef20ae4c6@postgrespro.ru> Message-ID: <1eca5819-2b58-e929-1bf3-2d4dadf491b9@2ndQuadrant.com> Date: Fri, 10 Aug 2018 17:55:06 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-MW List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 06/25/2018 05:32 AM, Konstantin Knizhnik wrote: > > > On 18.06.2018 23:34, Robbie Harwood wrote: >> >> ### >> >> Documentation!  You're going to need it.  There needs to be enough >> around for other people to implement the protocol (or if you prefer, >> enough for us to debug the protocol as it exists). >> >> In conjunction with that, please add information on how to set up >> compressed vs. uncompressed connections - similarly to how we've >> documentation on setting up TLS connection (though presumably compressed >> connection documentation will be shorter). >> > > Document protocol changes needed for libpq compression. > This thread appears to have gone quiet. What concerns me is that there appears to be substantial disagreement between the author and the reviewers. Since the last thing was this new patch it should really have been put back into "needs review" (my fault to some extent - I missed that). So rather than return the patch with feedfack I'm going to set it to "needs review" and move it to the next CF. However, if we can't arrive at a consensus about the direction during the next CF it should be returned with feedback. cheers andrew -- Andrew Dunstan https://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services