Message-ID: <1ecfeb4d2b1b7f119fa917d3052a3aecfaf4f425.camel@j-davis.com>
Subject: Re: Built-in CTYPE provider
From: Jeff Davis <pgsql@j-davis.com>
To: Noah Misch <noah@leadboat.com>
Cc: Peter Eisentraut <peter@eisentraut.org>, Daniel Verite
	 <daniel@manitou-mail.org>, Robert Haas <robertmhaas@gmail.com>, Jeremy
	Schneider <schneider@ardentperf.com>, pgsql-hackers@postgresql.org
Date: Mon, 01 Jul 2024 12:24:15 -0700
In-Reply-To: <20240629220857.fb.nmisch@google.com>
References: <3bc653b5d562ae9e2838b11cb696816c328a489a.camel@j-davis.com>
	 <163f4e2190cdf67f67016044e503c5004547e5a9.camel@j-davis.com>
	 <6bdb98e68b2b05aa71f7f934e227738eac84ecee.camel@j-davis.com>
	 <19b34a70-f5cf-4faf-88dc-917db44ed48d@eisentraut.org>
	 <846a7e1fa2024918b58ff7583523a2f3de9a11b4.camel@j-davis.com>
	 <3117d30aa911b408b90420f4f280fa0c3b5851be.camel@j-davis.com>
	 <4135cf11-206d-40ed-96c0-9363c1232379@eisentraut.org>
	 <7451f81ba0cb512222ab759de8ca1cffe44e9acb.camel@j-davis.com>
	 <1f309153-8198-4efa-86dd-8c304ec0040c@eisentraut.org>
	 <a21b515000f121244db2a5570d4292d19df23379.camel@j-davis.com>
	 <20240629220857.fb.nmisch@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu2 
MIME-Version: 1.0
Archived-At: <https://www.postgresql.org/message-id/1ecfeb4d2b1b7f119fa917d3052a3aecfaf4f425.camel%40j-davis.com>
Precedence: bulk

On Sat, 2024-06-29 at 15:08 -0700, Noah Misch wrote:
> lower(), initcap(), upper(), and regexp_matches() are
> PROVOLATILE_IMMUTABLE.
> Until now, we've delegated that responsibility to the user.=C2=A0 The use=
r
> is
> supposed to somehow never update libc or ICU in a way that changes
> outcomes
> from these functions.

To me, "delegated" connotes a clear and organized transfer of
responsibility to the right person to solve it. In that sense, I
disagree that we've delegated it.

What's happened here is evolution of various choices that seemed
reasonable at the time. Unfortunately, the consequences that are hard
for us to manage and even harder for users to manage themselves.

> =C2=A0 Now that postgresql.org is taking that responsibility
> for builtin C.UTF-8, how should we govern it?=C2=A0 I think the above tex=
t
> and [1]
> convey that we'll update the Unicode data between major versions,
> making
> functions like lower() effectively STABLE.=C2=A0 Is that right?

Marking them STABLE is not a viable option, that would break a lot of
valid use cases, e.g. an index on LOWER().

Unicode already has its own governance, including a stability policy
that includes case mapping:

https://www.unicode.org/policies/stability_policy.html#Case_Pair

Granted, that policy does not guarantee that the results will never
change. In particular, the results can change if using unassinged code
poitns that are later assigned to Cased characters.

That's not terribly common though; for instance, there are zero changes
in uppercase/lowercase behavior between Unicode 14.0 (2021) and 15.1
(current) -- even for code points that were unassigned in 14.0 and
later assigned. I checked this by modifying case_test.c to look at
unassigned code points as well.

There's a greater chance that character properties can change (e.g.
whether a character is "alphabetic" or not) in new releases of Unicode.
Such properties can affect regex character classifications, and in some
cases the results of initcap (because it uses the "alphanumeric"
classification to determine word boundaries).

I don't think we need code changes for 17. Some documentation changes
might be helpful, though. Should we have a note around LOWER()/UPPER()
that users should REINDEX any dependent indexes when the provider is
updated?

> (This thread had some discussion[2] that datcollversion/collversion
> won't
> necessarily change when a major versions changes lower() behavior.)

datcollversion/collversion track the vertsion of the collation
specifically (text ordering only), not the ctype (character semantics).
When using the libc provider, get_collation_actual_version() completely
ignores the ctype.

It would be interesting to consider tracking the versions separately,
though.

Regards,
	Jeff Davis