Message-ID: <1eeeebf37fda63cf0946e9b77e5bd6a8ac827615.camel@cybertec.at>
Subject: Re: Memory leak in incremental sort re-scan
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: Tomas Vondra <tomas.vondra@enterprisedb.com>, Tom Lane
 <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Date: Thu, 29 Jun 2023 13:49:54 +0200
In-Reply-To: <c4df75a8-b274-9a65-8815-74de587865b7@enterprisedb.com>
References: <b2bd02dff61af15e3526293e2771f874cf2a3be7.camel@cybertec.at>
	 <99e584a1-2f55-a56d-efb1-d38c57eb2beb@enterprisedb.com>
	 <2267955.1686859883@sss.pgh.pa.us>
	 <0643dbc2-53a6-37ac-b567-243a489cef0f@enterprisedb.com>
	 <2275724.1686861393@sss.pgh.pa.us>
	 <c4df75a8-b274-9a65-8815-74de587865b7@enterprisedb.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) 
MIME-Version: 1.0
Archived-At: <https://www.postgresql.org/message-id/1eeeebf37fda63cf0946e9b77e5bd6a8ac827615.camel%40cybertec.at>
Precedence: bulk

On Fri, 2023-06-16 at 00:34 +0200, Tomas Vondra wrote:
> On 6/15/23 22:36, Tom Lane wrote:
> > Tomas Vondra <tomas.vondra@enterprisedb.com> writes:
> > > On 6/15/23 22:11, Tom Lane wrote:
> > > > I see zero leakage in that example after applying the attached quic=
k
> > > > hack.=C2=A0 (It might be better to make the check in the caller, or=
 to just
> > > > move the call to ExecInitIncrementalSort.)
> >=20
> > > Thanks for looking. Are you planning to work on this and push the fix=
,
> > > or do you want me to finish this up?
> >=20
> > I'm happy to let you take it -- got lots of other stuff on my plate.
>=20
> OK, will do.

It would be cool if we could get that into the next minor release in August=
.

Yours,
Laurenz Albe