Feedback-ID: ie0a040ee:Fastmail
Message-ID: <1f4d0b80-3fea-4f4d-8d33-a652ea23e90b@eisentraut.org>
Date: Wed, 4 Feb 2026 15:44:05 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Pasword expiration warning
To: Nathan Bossart <nathandbossart@gmail.com>,
 Gilles Darold <gilles@darold.net>
Cc: Zsolt Parragi <zsolt.parragi@percona.com>, Japin Li
 <japinli@hotmail.com>, Yuefei Shi <shiyuefei1004@gmail.com>,
 songjinzhou <tsinghualucky912@foxmail.com>,
 PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
 Andrew Dunstan <andrew@dunslane.net>, Tom Lane <tgl@sss.pgh.pa.us>,
 liu xiaohui <liuxh.zj.cn@gmail.com>, Steven Niu <niushiji@gmail.com>
References: <f7d6e318-415a-4b98-86b0-28ae954707cc@darold.net>
 <CAN4CZFMBj-mZq_o8BtQz_TgqDTALbn31kc-SFtWE4FR1N-4RBw@mail.gmail.com>
 <MEAPR01MB3031CF12043573A245D931AAB69EA@MEAPR01MB3031.ausprd01.prod.outlook.com>
 <CAN4CZFP4AGeO-AynwE3e62XOKqaYnXtcGT1qfj=6nw2t5FOXwA@mail.gmail.com>
 <aXuehKtwtUXWVFYp@nathan> <197512e0-8116-4776-a600-822d29ee68a6@darold.net>
 <aYDZA3r3lG2oKc5D@nathan> <c933b0f1-ed95-4327-aca6-538acd2c547f@darold.net>
 <aYDlAhyYkjaEoEm7@nathan> <aYEJhk83XAqk76dP@nathan> <aYIUMbyDWobSi94m@nathan>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <aYIUMbyDWobSi94m@nathan>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/1f4d0b80-3fea-4f4d-8d33-a652ea23e90b%40eisentraut.org>
Precedence: bulk

On 03.02.26 16:28, Nathan Bossart wrote:
> +			detail = psprintf(_("The password for role \"%s\" will expire in "
> +								INT64_FORMAT " day(s), " INT64_FORMAT
> +								" hour(s), " INT64_FORMAT " minute(s)."),
> +							  role, days, hours, minutes);

You cannot use INT64_FORMAT inside translatable messages.  But you can 
use PRId64.

Using the type TimestampTz for what are essentially interval/duration 
quantities is a bit weird and confusing.  So maybe another placeholder 
would be more appropriate.

That said, I find writing plurals with "(s)" kind of lame.  It's not a 
good look.

It's a bit difficult to do this correctly when you have three separate 
values in one string.  I would consider for example just showing the 
number of days if the value is larger than one day, number hours if it's 
larger than one hour, else minutes.  I don't think you need 
minute-precision when the expiration time is several days out. 
Alternatively, just print the actual expiration timestamp.