Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qAWbl-0005tE-V4 for pgsql-hackers@arkaria.postgresql.org; Sat, 17 Jun 2023 14:08:53 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1qAWbj-0005zO-RC for pgsql-hackers@arkaria.postgresql.org; Sat, 17 Jun 2023 14:08:51 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qAWbj-0005zF-Cz for pgsql-hackers@lists.postgresql.org; Sat, 17 Jun 2023 14:08:51 +0000 Received: from relay9-d.mail.gandi.net ([217.70.183.199]) by makus.postgresql.org with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qAWbb-002iVW-8Q for pgsql-hackers@postgresql.org; Sat, 17 Jun 2023 14:08:49 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 322ACFF805; Sat, 17 Jun 2023 14:08:33 +0000 (UTC) Content-Type: multipart/alternative; boundary="------------hBSpGTQZGR2dD1lQqeyxJacm" Message-ID: <1f594a4b-14c8-e159-b250-edf8a091320d@dunslane.net> Date: Sat, 17 Jun 2023 10:08:32 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: run pgindent on a regular basis / scripted manner Content-Language: en-US From: Andrew Dunstan To: Jelte Fennema Cc: Michael Paquier , "shiy.fnst@fujitsu.com" , Robert Haas , Tom Lane , Justin Pryzby , Andres Freund , Noah Misch , Peter Geoghegan , Bruce Momjian , Magnus Hagander , Alvaro Herrera , Stephen Frost , Jesse Zhang , "pgsql-hackers@postgresql.org" , Peter Eisentraut References: <3d67bc80-4de2-5ba8-e272-e4ad2e59ba04@dunslane.net> <4ac8f263-f1bb-faa5-a307-1fffe00f0e3e@dunslane.net> <0f074818-b01a-799f-3c74-5fb5deab1d23@dunslane.net> <1d66447e-a77b-ca0d-90a0-782800e85383@dunslane.net> <582c503b-cd98-1891-ff87-9c8e8ce73ee5@dunslane.net> <30a72ba4-9ca4-15b5-db0f-0e68cba7ab26@dunslane.net> In-Reply-To: <30a72ba4-9ca4-15b5-db0f-0e68cba7ab26@dunslane.net> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------hBSpGTQZGR2dD1lQqeyxJacm Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2023-06-15 Th 12:12, Andrew Dunstan wrote: > > > On 2023-06-15 Th 11:26, Jelte Fennema wrote: >> On Sat, 22 Apr 2023 at 13:42, Andrew Dunstan wrote: >>> Perhaps we should start with a buildfarm module, which would run pg_indent --show-diff. That would only need to run on one animal, so a failure wouldn't send the whole buildfarm red. This would be pretty easy to do. >> Just to be clear on where we are. Is there anything blocking us from >> doing this, except for the PG16 branch cut? (that I guess is planned >> somewhere in July?) >> >> Just doing this for pgindent and not for perltidy would already be a >> huge improvement over the current situation IMHO. > > > The short answer is that some high priority demands from $dayjob got > in the way. However, I hope to have it done soon. > See I have set up a new buildfarm animal called koel which will run the module. cheers andrew -- Andrew Dunstan EDB:https://www.enterprisedb.com --------------hBSpGTQZGR2dD1lQqeyxJacm Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit


On 2023-06-15 Th 12:12, Andrew Dunstan wrote:


On 2023-06-15 Th 11:26, Jelte Fennema wrote:
On Sat, 22 Apr 2023 at 13:42, Andrew Dunstan <andrew@dunslane.net> wrote:

Perhaps we should start with a buildfarm module, which would run pg_indent --show-diff. That would only need to run on one animal, so a failure wouldn't send the whole buildfarm red. This would be pretty easy to do.

Just to be clear on where we are. Is there anything blocking us from
doing this, except for the PG16 branch cut? (that I guess is planned
somewhere in July?)

Just doing this for pgindent and not for perltidy would already be a
huge improvement over the current situation IMHO.


The short answer is that some high priority demands from $dayjob got in the way. However, I hope to have it done soon.



See <https://github.com/PGBuildFarm/client-code/commit/f9c1c15048b412d34ccda8020d989b3a7b566c05>


I have set up a new buildfarm animal called koel which will run the module.


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com
--------------hBSpGTQZGR2dD1lQqeyxJacm--