Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pcLun-0004j1-FO for pgsql-hackers@arkaria.postgresql.org; Wed, 15 Mar 2023 07:51:17 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pcLul-0001pc-6n for pgsql-hackers@arkaria.postgresql.org; Wed, 15 Mar 2023 07:51:15 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pcLuk-0001pS-2L for pgsql-hackers@lists.postgresql.org; Wed, 15 Mar 2023 07:51:14 +0000 Received: from new3-smtp.messagingengine.com ([66.111.4.229]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pcLue-0002kk-Ld for pgsql-hackers@postgresql.org; Wed, 15 Mar 2023 07:51:12 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id A717C581C3E for ; Wed, 15 Mar 2023 03:51:06 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 15 Mar 2023 03:51:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1678866666; x=1678873866; bh=JvMiiYLWL4tP+4kPvZXI9qAYpk1XcxRpe6i NbRYw8Ws=; b=Vn03DpwA0ZCeyj3++vz7myIk4L7U4x5iXvmBGoun2FnS2aAyplZ ZzYBMgv3xnH+jyPtuK77A9ZsAKe9/yU/tc8d4Nv7N9TJJ3BFe8KBi1uv2sIWrTQO j+YctE5b99mhkejTtDZt0HlaylOhcapeVK5dF1j4jfYdvAJJJlgnaUsImqwzWnJj J5Ci1/YT4U/D1k/dBAz2SGF6jRvxP4oetMWG4BhJ2jupdlCBDgFJc84w/lPNfWYN C//cPStvneMH8Q/cRSqDOlTSmVNkLNfCFrXKRzfsPF5vd+w1Isj2HhqDt44Ad6sN Q/RdK8bAgueN9HWTJe4rRfKICnz5U7cEqCQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvddvjedguddtlecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurheptgfkffggfgfhuffvsehmtderre dtfeejnecuhfhrohhmpefrvghtvghrucfgihhsvghnthhrrghuthcuoehpvghtvghrrdgv ihhsvghnthhrrghuthesvghnthgvrhhprhhishgvuggsrdgtohhmqeenucggtffrrghtth gvrhhnpefhheduhfdvheejjeeuffeffffhgedvuddvjeeluddtjeffhfeffedukeevfefh vdenucffohhmrghinhepghhithhhuhgsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepphgvthgvrhdrvghishgvnhhtrhgruhhtsegv nhhtvghrphhrihhsvggusgdrtghomh X-ME-Proxy: Feedback-ID: i131946ab:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Wed, 15 Mar 2023 03:51:05 -0400 (EDT) Content-Type: multipart/mixed; boundary="------------3dBeGu3oalSKLvJ4pkP0ADgg" Message-ID: <1fb52d61-0964-2d8e-87d9-e8be830e2b24@enterprisedb.com> Date: Wed, 15 Mar 2023 08:51:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US From: Peter Eisentraut Subject: pkg-config Requires.private entries should be comma-separated To: pgsql-hackers List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------3dBeGu3oalSKLvJ4pkP0ADgg Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit While comparing the .pc (pkg-config) files generated by the make and meson builds, I noticed that the Requires.private entries use different delimiters. The make build uses spaces, the meson build uses commas. The pkg-config documentation says that it should be comma-separated, but apparently about half the .pc in the wild use just spaces. The pkg-config source code acknowledges that both commas and spaces work: https://github.com/freedesktop/pkg-config/blob/master/parse.c#L273 https://github.com/pkgconf/pkgconf/blob/master/libpkgconf/dependency.c#L286 I think for consistency we should change the make build to use commas anyway. See attached patch. --------------3dBeGu3oalSKLvJ4pkP0ADgg Content-Type: text/plain; charset=UTF-8; name="0001-pkg-config-Requires.private-entries-should-be-comma-.patch" Content-Disposition: attachment; filename*0="0001-pkg-config-Requires.private-entries-should-be-comma-.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA1NTAxZmQ5NTI1NjY2NTRlNDliY2Y1YjhiNGQ1ZGM2YzEwMjZhOTBiIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBFaXNlbnRyYXV0IDxwZXRlckBlaXNlbnRy YXV0Lm9yZz4KRGF0ZTogV2VkLCAxNSBNYXIgMjAyMyAwODo0MjoyNyArMDEwMApTdWJqZWN0 OiBbUEFUQ0hdIHBrZy1jb25maWcgUmVxdWlyZXMucHJpdmF0ZSBlbnRyaWVzIHNob3VsZCBi ZSBjb21tYS1zZXBhcmF0ZWQKCi0tLQogc3JjL2ludGVyZmFjZXMvZWNwZy9jb21wYXRsaWIv TWFrZWZpbGUgfCAyICstCiBzcmMvaW50ZXJmYWNlcy9lY3BnL2VjcGdsaWIvTWFrZWZpbGUg ICB8IDIgKy0KIHNyYy9pbnRlcmZhY2VzL2xpYnBxL01ha2VmaWxlICAgICAgICAgIHwgMiAr LQogMyBmaWxlcyBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCgpk aWZmIC0tZ2l0IGEvc3JjL2ludGVyZmFjZXMvZWNwZy9jb21wYXRsaWIvTWFrZWZpbGUgYi9z cmMvaW50ZXJmYWNlcy9lY3BnL2NvbXBhdGxpYi9NYWtlZmlsZQppbmRleCBkYTQ3MGU1NDE4 Li5iOTQ4M2ZiYTA4IDEwMDY0NAotLS0gYS9zcmMvaW50ZXJmYWNlcy9lY3BnL2NvbXBhdGxp Yi9NYWtlZmlsZQorKysgYi9zcmMvaW50ZXJmYWNlcy9lY3BnL2NvbXBhdGxpYi9NYWtlZmls ZQpAQCAtMzIsNyArMzIsNyBAQCBPQkpTID0gXAogCSQoV0lOMzJSRVMpIFwKIAlpbmZvcm1p eC5vCiAKLVBLR19DT05GSUdfUkVRVUlSRVNfUFJJVkFURSA9IGxpYmVjcGcgbGlicGd0eXBl cworUEtHX0NPTkZJR19SRVFVSVJFU19QUklWQVRFID0gbGliZWNwZywgbGlicGd0eXBlcwog CiBhbGw6IGFsbC1saWIKIApkaWZmIC0tZ2l0IGEvc3JjL2ludGVyZmFjZXMvZWNwZy9lY3Bn bGliL01ha2VmaWxlIGIvc3JjL2ludGVyZmFjZXMvZWNwZy9lY3BnbGliL01ha2VmaWxlCmlu ZGV4IDZmYWRlYmY1M2QuLjY1MmUwMjM0MDUgMTAwNjQ0Ci0tLSBhL3NyYy9pbnRlcmZhY2Vz L2VjcGcvZWNwZ2xpYi9NYWtlZmlsZQorKysgYi9zcmMvaW50ZXJmYWNlcy9lY3BnL2VjcGds aWIvTWFrZWZpbGUKQEAgLTQxLDcgKzQxLDcgQEAgU0hMSUJfUFJFUkVRUyA9IHN1Ym1ha2Ut bGlicHEgc3VibWFrZS1wZ3R5cGVzbGliCiAKIFNITElCX0VYUE9SVFMgPSBleHBvcnRzLnR4 dAogCi1QS0dfQ09ORklHX1JFUVVJUkVTX1BSSVZBVEUgPSBsaWJwcSBsaWJwZ3R5cGVzCitQ S0dfQ09ORklHX1JFUVVJUkVTX1BSSVZBVEUgPSBsaWJwcSwgbGlicGd0eXBlcwogCiBhbGw6 IGFsbC1saWIKIApkaWZmIC0tZ2l0IGEvc3JjL2ludGVyZmFjZXMvbGlicHEvTWFrZWZpbGUg Yi9zcmMvaW50ZXJmYWNlcy9saWJwcS9NYWtlZmlsZQppbmRleCBjMThlOTE0MjI4Li4wOTE5 ZDhmMzJmIDEwMDY0NAotLS0gYS9zcmMvaW50ZXJmYWNlcy9saWJwcS9NYWtlZmlsZQorKysg Yi9zcmMvaW50ZXJmYWNlcy9saWJwcS9NYWtlZmlsZQpAQCAtOTYsNyArOTYsNyBAQCBTSExJ Ql9QUkVSRVFTID0gc3VibWFrZS1saWJwZ3BvcnQKIFNITElCX0VYUE9SVFMgPSBleHBvcnRz LnR4dAogCiBpZmVxICgkKHdpdGhfc3NsKSxvcGVuc3NsKQotUEtHX0NPTkZJR19SRVFVSVJF U19QUklWQVRFID0gbGlic3NsIGxpYmNyeXB0bworUEtHX0NPTkZJR19SRVFVSVJFU19QUklW QVRFID0gbGlic3NsLCBsaWJjcnlwdG8KIGVuZGlmCiAKIGFsbDogYWxsLWxpYiBsaWJwcS1y ZWZzLXN0YW1wCi0tIAoyLjM5LjIKCg== --------------3dBeGu3oalSKLvJ4pkP0ADgg--