Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1obUYT-0008Qm-5v for pgsql-hackers@arkaria.postgresql.org; Thu, 22 Sep 2022 22:20:25 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1obUYR-0004QF-Oh for pgsql-hackers@arkaria.postgresql.org; Thu, 22 Sep 2022 22:20:23 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1obUYR-0004Q6-F9 for pgsql-hackers@lists.postgresql.org; Thu, 22 Sep 2022 22:20:23 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1obUYO-0005vm-Md for pgsql-hackers@lists.postgresql.org; Thu, 22 Sep 2022 22:20:23 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 28MMKFMC2000545; Thu, 22 Sep 2022 18:20:15 -0400 From: Tom Lane To: Peter Geoghegan cc: David Rowley , PostgreSQL Hackers , Andres Freund Subject: Re: Making C function declaration parameter names consistent with corresponding definition names In-reply-to: References: <3913123.1663370391@sss.pgh.pa.us> <3922750.1663372191@sss.pgh.pa.us> <3955318.1663377656@sss.pgh.pa.us> <29327.1663439185@sss.pgh.pa.us> <1990814.1663883711@sss.pgh.pa.us> Comments: In-reply-to Peter Geoghegan message dated "Thu, 22 Sep 2022 15:14:21 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2000543.1663885215.1@sss.pgh.pa.us> Date: Thu, 22 Sep 2022 18:20:15 -0400 Message-ID: <2000544.1663885215@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Peter Geoghegan writes: > That makes it easy, then. I'll just take the least invasive approach > possible with pg_dump: treat the names from function definitions as > authoritative, and mechanically adjust the function declarations as > needed to make everything agree. WFM. regards, tom lane