From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
cc: Andres Freund <andres@anarazel.de>, Tomas Vondra <tomas@vondra.me>,
        Jakub Wartak <jakub.wartak@enterprisedb.com>,
        Robert Haas <robertmhaas@gmail.com>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: scalability bottlenecks with (many) partitions (and more)
In-reply-to: <8a1a5c10-0644-4ea0-a9e8-73d3a2908e18@dunslane.net>
References: <7c1eeafb-2375-4ff6-8469-0640d52d44ed@vondra.me> <ffiwtzc6vedo6wb4gbwelon5nefqg675t5c7an2ta7pcz646cg@qwmkdb3l4ett> <bfca1010-e5f1-4e36-a461-61b6aad60c47@vondra.me> <5xahykogf2sg3ofdqk2li7xx3t2vh23m42jnvfwxoi5fhh7iya@girlhoxdxjzc> <486baeb2-2adc-48d2-ba9d-13c4ae43301c@vondra.me> <vgtms7b5egxdypmknxpobocqton3puhprk3ahhk45rcx4uyl33@6uetxejsc75r> <733e72fa-5fc2-48fc-ab1f-1d8f1ab387c3@vondra.me> <d5499660-1541-4749-aff4-6be88be76d99@vondra.me> <nubyc3twqd7mtuyc2rbbt2yazjzbat6mlpfgxtb2ppv2egci3g@uvptf7xmh46m> <193453.1741123834@sss.pgh.pa.us> <qdvrgej743lcddjnb4lzyakt3f5bs2oz34r274wbmgc2g4474q@utqqrqiih65h> <197167.1741125678@sss.pgh.pa.us> <8a1a5c10-0644-4ea0-a9e8-73d3a2908e18@dunslane.net>
Comments: In-reply-to Andrew Dunstan <andrew@dunslane.net>
	message dated "Tue, 04 Mar 2025 17:09:43 -0500"
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="----- =_aaaaaaaaaa0"
Content-ID: <199832.1741127288.0@sss.pgh.pa.us>
Date: Tue, 04 Mar 2025 17:28:55 -0500
Message-ID: <200085.1741127335@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/200085.1741127335%40sss.pgh.pa.us>
Precedence: bulk

------- =_aaaaaaaaaa0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <199832.1741127288.1@sss.pgh.pa.us>

Andrew Dunstan <andrew@dunslane.net> writes:
> I think I found a logic bug. Testing.

Not sure what you are looking at, but I was trying to fix it
by making the loop over test modules skip unbuilt modules,
borrowing the test you added in v19 to skip unbuilt contrib
modules.  It's a little more complicated for the other modules
because some of them have no .c files to be built, and I could
not get that to work.  I eventually concluded that there's
something wrong with the "scalar glob()" idiom you used.
A bit of googling suggested "grep -e, glob()" instead, and
that seems to work for me.  sifaka seems happy with the
attached patch.

			regards, tom lane


------- =_aaaaaaaaaa0
Content-Type: text/x-diff; name="run-build-fix.patch"; charset="us-ascii"
Content-ID: <199832.1741127288.2@sss.pgh.pa.us>
Content-Description: run-build-fix.patch

--- run_build.pl~	2025-03-04 16:34:04.082252563 -0500
+++ run_build.pl	2025-03-04 16:35:25.967357487 -0500
@@ -2483,6 +2483,11 @@ sub run_misc_tests
 		my $testname = basename($testdir);
 		next if $testname =~ /ssl/ && !$using_ssl;
 		next unless -d "$testdir/t";
+
+		# can't test it if we haven't built it
+		next unless grep -e, glob("$testdir/*.o $testdir/*.obj")
+			or not grep -e, glob("$testdir/*.c");
+
 		next if $using_msvc && $testname eq 'pg_bsd_indent';
 		next unless step_wanted("module-$testname");
 		print time_str(), "running misc test module-$testname ...\n"
@@ -2496,7 +2501,7 @@ sub run_misc_tests
 		my $testname = basename($testdir);
 
 		# can't test it if we haven't built it
-		next unless scalar glob("$testdir/*.o $testdir/*.obj");
+		next unless grep -e, glob("$testdir/*.o $testdir/*.obj");
 
 		# skip sepgsql unless it's marked for testing
 		next if $testname eq 'sepgsql' && $ENV{PG_TEST_EXTRA} !~ /\bsepgsql\b/;

------- =_aaaaaaaaaa0--