Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wWNuK-002ZjP-2n for pgsql-hackers@arkaria.postgresql.org; Mon, 08 Jun 2026 00:32:00 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wWNuJ-000IdH-2k for pgsql-hackers@arkaria.postgresql.org; Mon, 08 Jun 2026 00:31:59 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wWNrH-000G6Q-19 for pgsql-hackers@lists.postgresql.org; Mon, 08 Jun 2026 00:28:51 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wWNrF-00000001bkz-2MXc for pgsql-hackers@lists.postgresql.org; Mon, 08 Jun 2026 00:28:50 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.18.1/8.18.1) with ESMTP id 6580SeHI200149; Sun, 7 Jun 2026 20:28:40 -0400 From: Tom Lane To: Michael Paquier cc: Peter Eisentraut , Alex Guo , Bertrand Drouvot , Ashutosh Bapat , pgsql-hackers@lists.postgresql.org Subject: Re: Fix DROP PROPERTY GRAPH "unsupported object class" error In-reply-to: References: <29c33fb6-4200-4a08-be3d-a1a2ceef23b8@eisentraut.org> Comments: In-reply-to Michael Paquier message dated "Mon, 08 Jun 2026 09:19:54 +0900" MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-ID: <200147.1780878520.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Sun, 07 Jun 2026 20:28:40 -0400 Message-ID: <200148.1780878520@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Michael Paquier writes: > + property graph element label | | | e of e of > create_property_graph_tests.gt > + property graph element label | | | v1 of v1 of > create_property_graph_tests.gt > + property graph element label | | | v2 of v2 of > create_property_graph_tests.gt > [...] > + property graph label property | | | c of e of e of > create_property_graph_tests.gt > + property graph label property | | | k1 of e of e of > create_property_graph_tests.gt > + property graph label property | | | k2 of e of e of > create_property_graph_tests.gt > FWIW, I still find these descriptions written as of "$object of > $object of..", or worse the "$object1 of $object2 of $object2 of..", > really hard to parse, and make some sense out of them. Am I the only > one? No. At the very least, these messages violate our style guidelines [1]: Type of the Object = When citing the name of an object, state what kind of object it is. Rationale: Otherwise no one will know what =E2=80=9Cfoo.bar.baz=E2=80=9D= refers to. I'm not sure whether adding that would be sufficient to make these intelligible, but surely it would help. I think your first example would come out like label e of property(?) e of property graph create_property_graph_tests= .gt regards, tom lane [1] https://www.postgresql.org/docs/current/error-style-guide.html#ERROR-S= TYLE-GUIDE-OBJECT-TYPE