Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fgX1y-0003ks-VH for pgsql-hackers@arkaria.postgresql.org; Fri, 20 Jul 2018 15:09:19 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fgX1x-0007cd-33 for pgsql-hackers@arkaria.postgresql.org; Fri, 20 Jul 2018 15:09:17 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fgX1w-0007cS-OQ for pgsql-hackers@lists.postgresql.org; Fri, 20 Jul 2018 15:09:16 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fgX1u-0004kI-Cl for pgsql-hackers@postgresql.org; Fri, 20 Jul 2018 15:09:15 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id w6KF9D87020016; Fri, 20 Jul 2018 11:09:13 -0400 From: Tom Lane To: Victor Wagner cc: pgsql-hackers Subject: Re: Non-portable shell code in pg_upgrade tap tests In-reply-to: <20180720175508.07776219@fafnir.local.vm> References: <20180720153820.69e9ae6c@fafnir.local.vm> <17833.1532096747@sss.pgh.pa.us> <20180720175508.07776219@fafnir.local.vm> Comments: In-reply-to Victor Wagner message dated "Fri, 20 Jul 2018 17:55:08 +0300" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <20014.1532099353.1@sss.pgh.pa.us> Date: Fri, 20 Jul 2018 11:09:13 -0400 Message-ID: <20015.1532099353@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Victor Wagner writes: > Tom Lane wrote: >> Please send a patch. Most of us do not have access to old shells > Here it goes. Previous letter was written before fixed tests were > completed, because this old machine is slow. Thanks. Will check on my own dinosaurs, and push if I don't find a problem. regards, tom lane