From: Bruce Momjian <pgman@candle.pha.pa.us>
Message-Id: <200307241518.h6OFIP726909@candle.pha.pa.us>
Subject: Re: libpq_r
In-Reply-To: <Pine.LNX.4.56.0307241716560.3595@krusty.credativ.de>
To: Peter Eisentraut <peter_e@gmx.net>
Date: Thu, 24 Jul 2003 11:18:25 -0400 (EDT)
Cc: Lee Kindness <lkindness@csl.co.uk>, Tom Lane <tgl@sss.pgh.pa.us>,
	PostgreSQL Development <pgsql-hackers@postgresql.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII

Peter Eisentraut wrote:
> Bruce Momjian writes:
> 
> > Now I see what you are saying, that _REENTRANT just makes it reentrant,
> 
> _REENTRANT only makes additional functions visible in the header files, it
> doesn't change any functions to behave differently.  (This is not hard to
> imagine, because the lack of reentrancy of most functions lies in the
> public interface, and you can't change that transparently.)
> 
> > and doesn't have a downside in terms of performance.
> 
> It follows from the above that this is irrelevant.
> 
> > However, notice the flags needed under Linux:
> >
> > 	THREAD_CFLAGS="-D_REENTRANT -D_THREAD_SAFE -D_POSIX_PTHREAD_SEMANTICS"
> 
> Those flags are bogus.  You don't need any flags under Linux.

Is that true for all versions of Linux?  Don't we need the first one so
we compile cleanly.

Also, the remaining to linux settings:

	THREAD_LIBS="-lpthread"
	NEED_REENTRANT_FUNC_NAMES=yes

I assume -lpthread does have an effect on the library, or does it?

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073