X-Original-To: pgsql-hackers-postgresql.org@localhost.postgresql.org Received: from localhost (av.hub.org [200.46.204.144]) by postgresql.org (Postfix) with ESMTP id E292611F6095 for ; Thu, 20 Apr 2006 08:19:54 -0300 (ADT) X-Virus-Scanned: by amavisd-new at hub.org X-Spam-Score: 0.09 X-Spam-Level: X-Spam-Status: No, score=0.09 required=5 tests=[AWL=0.090] Received: from postgresql.org ([200.46.204.71]) by localhost (av.hub.org [200.46.204.144]) (amavisd-new, port 10024) with ESMTP id Jx3MfMLluQz6 for ; Thu, 20 Apr 2006 08:19:47 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey- Received: from gauss.credativ.com (ipx11302.ipxserver.de [212.112.227.254]) by postgresql.org (Postfix) with ESMTP id 7DF6611F644A for ; Thu, 20 Apr 2006 08:19:49 -0300 (ADT) Received: from bell.credativ.de (p508952CC.dip.t-dialin.net [80.137.82.204]) (using TLSv1 with cipher EXP1024-RC4-SHA (56/128 bits)) (No client certificate requested) by gauss.credativ.com (Postfix) with ESMTP id DEA25D790F; Thu, 20 Apr 2006 13:19:48 +0200 (CEST) From: Peter Eisentraut To: "Magnus Hagander" Subject: Re: pg_dump -Ft failed on Windows XP Date: Thu, 20 Apr 2006 13:19:47 +0200 User-Agent: KMail/1.9.1 Cc: pgsql-hackers@postgresql.org, "Yoshiyuki Asaba" References: <6BCB9D8A16AC4241919521715F4D8BCEA352D0@algol.sollentuna.se> In-Reply-To: <6BCB9D8A16AC4241919521715F4D8BCEA352D0@algol.sollentuna.se> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200604201319.48123.peter_e@gmx.net> X-Archive-Number: 200604/713 X-Sequence-Number: 82436 Am Donnerstag, 20. April 2006 13:03 schrieb Magnus Hagander: > Question: Is the use of O_TEMPORARY to open() portable? (my win32 docs > say it will make the file automatically deleted when the last descriptor > is closed, which I didn't know before. That would make the patch much > simpler, but might require #ifdefs?) I think it would be more elegant if you wrote a replacement implementation of tmpfile() for pgport and did not change pg_dump at all. And/or write a bug to Microsoft about a buggy C library. :) -- Peter Eisentraut http://developer.postgresql.org/~petere/