X-Original-To: pgsql-hackers-postgresql.org@localhost.postgresql.org
Received: from localhost (av.hub.org [200.46.204.144])
	by postgresql.org (Postfix) with ESMTP id E497211F675F
	for <pgsql-hackers-postgresql.org@localhost.postgresql.org>;
	Thu, 20 Apr 2006 12:48:12 -0300 (ADT)
X-Virus-Scanned: by amavisd-new at hub.org
X-Spam-Score: 0.112
X-Spam-Level: 
X-Spam-Status: No, score=0.112 required=5 tests=[AWL=0.112]
Received: from postgresql.org ([200.46.204.71])
	by localhost (av.hub.org [200.46.204.144]) (amavisd-new, port 10024)
	with ESMTP id lA1mIDpWg+11
	for <pgsql-hackers-postgresql.org@localhost.postgresql.org>;
	Thu, 20 Apr 2006 12:48:08 -0300 (ADT)
X-Greylist: from auto-whitelisted by SQLgrey-
Received: from svana.org (svana.org [125.62.94.225])
	by postgresql.org (Postfix) with ESMTP id BF84A11F6757
	for <pgsql-hackers@postgresql.org>;
	Thu, 20 Apr 2006 12:48:06 -0300 (ADT)
Received: from kleptog by svana.org with local (Exim 4.50)
	id 1FWbO1-0001ny-LP; Fri, 21 Apr 2006 01:48:05 +1000
Date: Thu, 20 Apr 2006 17:48:05 +0200
From: Martijn van Oosterhout <kleptog@svana.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Google SoC--Idea Request
Message-ID: <20060420154805.GD1984@svana.org>
Reply-To: Martijn van Oosterhout <kleptog@svana.org>
References: <36e682920604151205i75a08030x7c05a6f52fccf095@mail.gmail.com>
	<AB8B2106-EA96-4577-845B-6604CC140AEC@pgedit.com>
	<36e682920604190909p68649a35m1953a7b4262b8852@mail.gmail.com>
	<200604200851.25569.xzilla@users.sourceforge.net>
	<20060420140501.GB1984@svana.org> <18559.1145545471@sss.pgh.pa.us>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="hxkXGo8AKqTJ+9QI"
Content-Disposition: inline
In-Reply-To: <18559.1145545471@sss.pgh.pa.us>
X-PGP-Key-ID: Length=1024; ID=0x0DC67BE6
X-PGP-Key-Fingerprint: 295F A899 A81A 156D B522  48A7 6394 F08A 0DC6 7BE6
X-PGP-Key-URL: <http://svana.org/kleptog/0DC67BE6.pgp.asc>
User-Agent: Mutt/1.5.9i
X-SA-Exim-Connect-IP: <locally generated>
X-SA-Exim-Mail-From: kleptog@svana.org
X-SA-Exim-Scanned: No (on svana.org); SAEximRunCond expanded to false
X-Archive-Number: 200604/731
X-Sequence-Number: 82454


--hxkXGo8AKqTJ+9QI
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Apr 20, 2006 at 11:04:31AM -0400, Tom Lane wrote:
> Martijn van Oosterhout <kleptog@svana.org> writes:
> > On Thu, Apr 20, 2006 at 08:51:25AM -0400, Robert Treat wrote:
> >> I think Martin Oosterhout's nearby email on coverity bug reports might=
 make a
> >> good SoC project, but should it also be added to the TODO list?
> > ...
> > In any case, after you weed out the false-positives and exclude ECPG
> > you're only talking about less than 50 issues that may need to be
> > addressed. Hardly a project that will take any amount of time.
>=20
> Nor one we'd be willing to wait till the summer to address, if any of
> the bugs are real.

Most of the stuff remaining is memory leaks in the src/bin directories,
and ECPG. The memory leaks are not important there (initdb leaks like a
sieve in many places).

About the only thing in the backend I found interesting was this:

src/backend/utils/hash/dynahash.c function hash_create

The numbers are line numbers. Somewhat squished version, hope I didn't
miss anything.

185  if( flags & HASH_SHARED_MEM) {
193      hashp->hcxt =3D NULL;
197      if (flags & HASH_ATTACH)
198  	     return hashp;
199  }
256  if (!init_htab(hashp, nelem))
257  {
258      hash_destroy(hashp);

hash_destroy dereferences hashp->hcxt. I don't see anything in
init_htab that special-cases shared memory hashes. The only way this
could be avoided is if HASH_SHARED_MEM was always combined with
HASH_ATTACH. But if so, why the test?

The only other thing we could do, if we were prepare to annotate the
source, is maybe teach it about our locking stuff and have it check
that. But I don't think that's suitable for mainline, more someone's
private tree...

Have a nice day,
--=20
Martijn van Oosterhout   <kleptog@svana.org>   http://svana.org/kleptog/
> From each according to his ability. To each according to his ability to l=
itigate.

--hxkXGo8AKqTJ+9QI
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFER601IB7bNG8LQkwRAgzQAJ4i5TIxBOusxZEDonrknSGEl9618wCfT1mA
tl6MkniY5uRVtp1DaiCv8+U=
=r/TL
-----END PGP SIGNATURE-----

--hxkXGo8AKqTJ+9QI--