X-Original-To: pgsql-hackers-postgresql.org@postgresql.org Received: from localhost (mx1.hub.org [200.46.208.251]) by postgresql.org (Postfix) with ESMTP id 8DF3C9FA4C1 for ; Fri, 16 Jun 2006 18:37:10 -0300 (ADT) Received: from postgresql.org ([200.46.204.71]) by localhost (mx1.hub.org [200.46.208.251]) (amavisd-new, port 10024) with ESMTP id 87179-07 for ; Fri, 16 Jun 2006 18:37:05 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey- Received: from candle.pha.pa.us (candle.pha.pa.us [70.90.9.53]) by postgresql.org (Postfix) with ESMTP id 318AD9FA10A for ; Fri, 16 Jun 2006 18:37:04 -0300 (ADT) Received: (from pgman@localhost) by candle.pha.pa.us (8.11.6/8.11.6) id k5GLaw916105; Fri, 16 Jun 2006 17:36:58 -0400 (EDT) From: Bruce Momjian Message-Id: <200606162136.k5GLaw916105@candle.pha.pa.us> Subject: Re: pg_dump -Ft failed on Windows XP In-Reply-To: To: Zeugswetter Andreas DCP SD Date: Fri, 16 Jun 2006 17:36:58 -0400 (EDT) CC: Tom Lane , Magnus Hagander , Peter Eisentraut , pgsql-hackers@postgresql.org, Yoshiyuki Asaba X-Mailer: ELM [version 2.4ME+ PL121 (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Virus-Scanned: Maia Mailguard 1.0.1 X-Archive-Number: 200606/816 X-Sequence-Number: 85049 Someday we can move this to /port, but for now, let's get it into CVS. Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. --------------------------------------------------------------------------- Zeugswetter Andreas DCP SD wrote: > > > >> Apparently it won't work at all if TMP isn't set? > > > > > I'm not *too* concerned about that, since TMP is normally set by the > OS > > > itself. There's one set in the "system environment" (to > c:\windows\temp > > > or whatrever) and then it's overridden by one set by the OS when it > > > loads a user profile. > > > > OK, then maybe not having it would be equivalent to /tmp-not-writable > > on Unix, ie, admin error. > > > > > Also to the point, what would you fall back to? > > > > Current directory maybe? > > It tries \ (tested on Win 2000), if the dir argument is NULL and TMP is > not set. > But TMP is usually set. > > Attached is a working version not yet adapted to port/. > - memoryleak fixed > - use _tmpname and _fdopen not the compatibility tmpname and fdopen > (imho only cosmetic) > - EACCES fixed (Win2000 needs _S_IREAD | _S_IWRITE or fails with EACCES, > even as Admin) > - I suggest adding a prefix pg_temp_ (for leftover temp files after > crash, > the name I get is then usually pg_temp_2) > > Andreas Content-Description: pg_dump_tempfile.patch.txt [ Attachment, skipping... ] > > ---------------------------(end of broadcast)--------------------------- > TIP 2: Don't 'kill -9' the postmaster -- Bruce Momjian http://candle.pha.pa.us EnterpriseDB http://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. +