Received: from localhost (unknown [200.46.204.183]) by developer.postgresql.org (Postfix) with ESMTP id 5F65F2E0032 for ; Sun, 11 May 2008 21:30:24 -0300 (ADT) Received: from developer.postgresql.org ([200.46.204.71]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 91231-01-3 for ; Sun, 11 May 2008 21:29:48 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from lists.commandprompt.com (host-159.commandprompt.net [207.173.203.159]) by developer.postgresql.org (Postfix) with ESMTP id DD4422E0071 for ; Sun, 11 May 2008 21:28:59 -0300 (ADT) Received: from perhan.alvh.no-ip.org (200-126-123-196.bk8-dsl.surnet.cl [200.126.123.196]) (authenticated bits=0) by lists.commandprompt.com (8.13.8/8.13.8) with ESMTP id m4C0TqTj011022 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 11 May 2008 17:29:56 -0700 Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id 9030247C5C; Sun, 11 May 2008 20:28:53 -0400 (CLT) Date: Sun, 11 May 2008 20:28:53 -0400 From: Alvaro Herrera To: Tom Lane Cc: Zdenek Kotala , Pg Hackers Subject: Re: bloated heapam.h Message-ID: <20080512002853.GD5746@alvh.no-ip.org> References: <20080509185610.GJ5748@alvh.no-ip.org> <48258C7C.9030103@sun.com> <20080510192615.GA9094@alvh.no-ip.org> <6911.1210453845@sss.pgh.pa.us> <20080511044745.GC9136@alvh.no-ip.org> <21641.1210531438@sss.pgh.pa.us> <20080512000642.GB5746@alvh.no-ip.org> <20080512002153.GC5746@alvh.no-ip.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080512002153.GC5746@alvh.no-ip.org> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0 (lists.commandprompt.com [207.173.203.159]); Sun, 11 May 2008 17:29:56 -0700 (PDT) X-Virus-Scanned: Maia Mailguard 1.0.1 X-Archive-Number: 200805/334 X-Sequence-Number: 118333 Alvaro Herrera wrote: > Oops :-( I just noticed that I removed bufmgr.h from bufpage.h, which > is a change you had objected to previously :-( However, it seems the right fix is to move BufferGetPageSize and BufferGetPage from bufpage.h to bufmgr.h. (Digging further, it seems like bufpage.h should also include transam.h in order to get TransactionIdIsNormal ... I start to wonder how many problems of this nature we have on our headers. Without having a way to detect whether the defined macros are valid, it seems hard to check programatically, however.) -- Alvaro Herrera http://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc.