From: Tom Lane <tgl@sss.pgh.pa.us>
To: Justin Pryzby <pryzby@telsasoft.com>
cc: Andres Freund <andres@anarazel.de>, Noah Misch <noah@leadboat.com>,
        Andrew Dunstan <andrew@dunslane.net>,
        Jelte Fennema <postgres@jeltef.nl>, Peter Geoghegan <pg@bowt.ie>,
        Bruce Momjian <bruce@momjian.us>,
        Magnus Hagander <magnus@hagander.net>,
        Alvaro Herrera <alvherre@2ndquadrant.com>,
        Stephen Frost <sfrost@snowman.net>, Jesse Zhang <sbjesse@gmail.com>,
        pgsql-hackers@postgresql.org
Subject: Re: run pgindent on a regular basis / scripted manner
In-reply-to: <20230204171101.GF1653@telsasoft.com>
References: <CAH2-Wzm0niYBPcN6eX3PzHABfj0dE3fwifo5bdturvMp=9FGqw@mail.gmail.com> <20230122094957.x542ojaqgi4lalq4@awork3.anarazel.de> <CAGECzQRYjHdNQ-Bq2yrBb-8s3Pjx7pfvYPDdNv9tcvDcscDhbg@mail.gmail.com> <20230122223806.3sgew6qswhsczae7@awork3.anarazel.de> <1489276.1674427657@sss.pgh.pa.us> <de0a7034-0186-1f91-b408-eb67f2a854dc@dunslane.net> <1708030.1675446770@sss.pgh.pa.us> <20230204041848.GC1896331@rfd.leadboat.com> <20230204113453.vmtnayjvhyg5qqqy@alap3.anarazel.de> <1923921.1675526879@sss.pgh.pa.us> <20230204171101.GF1653@telsasoft.com>
Comments: In-reply-to Justin Pryzby <pryzby@telsasoft.com>
	message dated "Sat, 04 Feb 2023 11:11:01 -0600"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2009471.1675532231.1@sss.pgh.pa.us>
Date: Sat, 04 Feb 2023 12:37:11 -0500
Message-ID: <2009472.1675532231@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/2009472.1675532231%40sss.pgh.pa.us>
Precedence: bulk

Justin Pryzby <pryzby@telsasoft.com> writes:
> Would you want to make those the default options of the in-tree indent ?
> Or provide a shortcut like --postgresql ?

Hmmm ... inserting all of those as the default options would likely
make it impossible to update pg_bsd_indent itself with anything like
its current indent style (not that it's terribly consistent about
that).  I could see inventing a --postgresql shortcut switch perhaps.

But it's not clear to me why you're allergic to the perl wrapper?
It's not like that's the only perl infrastructure in our build process.
Also, whether or not we could push some of what it does into pg_bsd_indent
proper, I can't see pushing all of it (for instance, the very PG-specific
list of typedef exclusions).

			regards, tom lane