Received: from maia.hub.org (unknown [200.46.204.183])
	by mail.postgresql.org (Postfix) with ESMTP id 8FFFD637122;
	Tue,  2 Feb 2010 15:18:12 -0400 (AST)
Received: from mail.postgresql.org ([200.46.204.86])
	by maia.hub.org (mx1.hub.org [200.46.204.183]) (amavisd-maia,
	port 10024)
	with ESMTP id 15765-05; Tue,  2 Feb 2010 19:18:01 +0000 (UTC)
X-Greylist: from auto-whitelisted by SQLgrey-1.7.6
X-Greylist: from auto-whitelisted by SQLgrey-1.7.6
Received: from mail.anarazel.de (mail.anarazel.de [217.115.131.40])
	by mail.postgresql.org (Postfix) with ESMTP id 73E01632BD5;
	Tue,  2 Feb 2010 15:08:18 -0400 (AST)
Received: from alap2.localnet (p579FAFE6.dip.t-dialin.net [87.159.175.230])
	by mail.anarazel.de (Postfix) with ESMTPSA id C02CC448005;
	Tue,  2 Feb 2010 20:08:15 +0100 (CET)
From: Andres Freund <andres@anarazel.de>
To: Robert Haas <robertmhaas@gmail.com>
Subject: Re: [HACKERS] Re: Faster CREATE DATABASE by delaying fsync (was 8.4.1
	ubuntu karmic slow createdb)
Date: Tue, 2 Feb 2010 20:08:12 +0100
User-Agent: KMail/1.13.0 (Linux/2.6.33-rc5-andres-00243-g6ea299e; KDE/4.3.95;
	x86_64; ; )
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Greg Stark <gsstark@mit.edu>,
	pgsql-hackers@postgresql.org, pgsql-performance@postgresql.org,
	Michael Clemmons <glassresistor@gmail.com>,
	Hannu Krosing <hannu@2ndquadrant.com>,
	Scott Marlowe <scott.marlowe@gmail.com>
References: <4427a97a0912101235x3ade510blcc00d5ce9883c6b6@mail.gmail.com>
	<201002021934.18444.andres@anarazel.de>
	<603c8f071002021106o5eef7b40r1ed21c9bd05251ec@mail.gmail.com>
In-Reply-To: <603c8f071002021106o5eef7b40r1ed21c9bd05251ec@mail.gmail.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201002022008.13898.andres@anarazel.de>
X-Virus-Scanned: Maia Mailguard 1.0.1
X-Spam-Status: No, hits=-0.74 tagged_above=-10 required=5 tests=BAYES_20=-0.74
X-Spam-Level: 
X-Archive-Number: 201002/23
X-Sequence-Number: 37444

On Tuesday 02 February 2010 20:06:32 Robert Haas wrote:
> On Tue, Feb 2, 2010 at 1:34 PM, Andres Freund <andres@anarazel.de> wrote:
> > For now it could - but it very well might be converted to sync_file_range
> > or similar, which would have different "sideeffects".
> > 
> > As the potential code duplication is rather small I would prefer to
> > describe the prime effect not the sideeffects...
> 
> Hmm, in that case, I think the problem is that this function has no
> comment explaining its intended charter.
I agree there. Greg, do you want to update the patch with some comments or 
shall I?

Andres