Received: from maia.hub.org (maia-5.hub.org [200.46.204.29]) by mail.postgresql.org (Postfix) with ESMTP id 88DAC1337B8A for ; Thu, 17 Feb 2011 15:45:31 -0400 (AST) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.29]) (amavisd-maia, port 10024) with ESMTP id 93454-07 for ; Thu, 17 Feb 2011 19:45:23 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from midnight-anchovy.ambulatoryclam.net (unknown [18.141.0.210]) by mail.postgresql.org (Postfix) with ESMTP id F069F1337B84 for ; Thu, 17 Feb 2011 15:45:22 -0400 (AST) Received: by midnight-anchovy.ambulatoryclam.net (Postfix, from userid 1001) id 42CAF4AC29; Thu, 17 Feb 2011 14:45:22 -0500 (EST) Date: Thu, 17 Feb 2011 14:45:22 -0500 From: Dan Ports To: YAMAMOTO Takashi Cc: Kevin.Grittner@wicourts.gov, pgsql-hackers@postgresql.org Subject: Re: SSI bug? Message-ID: <20110217194522.GA98448@csail.mit.edu> References: <4D592869020000250003A99A@gw.wicourts.gov> <20110216221335.C9A2119CF21@mail.netbsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110216221335.C9A2119CF21@mail.netbsd.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-1.107 tagged_above=-5 required=5 tests=BAYES_00=-1.9, RDNS_NONE=0.793 X-Spam-Level: X-Archive-Number: 201102/1736 X-Sequence-Number: 182525 On Wed, Feb 16, 2011 at 10:13:35PM +0000, YAMAMOTO Takashi wrote: > i got the following SEGV when runnning vacuum on a table. > (the line numbers in predicate.c is different as i have local modifications.) > oldlocktag.myTarget was NULL. > it seems that TransferPredicateLocksToNewTarget sometimes use stack garbage > for newpredlocktag.myTarget. vacuum on the table succeeded with the attached > patch. the latter part of the patch was necessary to avoid targetList > corruption, which later seems to make DeleteChildTargetLocks loop inifinitely. Oops. Those are both definitely bugs (and my fault). Your patch looks correct. Thanks for catching that! Dan -- Dan R. K. Ports MIT CSAIL http://drkp.net/