Received: from makus.postgresql.org (makus.postgresql.org [98.129.198.125]) by mail.postgresql.org (Postfix) with ESMTP id 128D91DCB2B1 for ; Mon, 27 Feb 2012 15:37:41 -0400 (AST) Received: from mail.anarazel.de ([217.115.131.40]) by makus.postgresql.org with esmtp (Exim 4.72) (envelope-from ) id 1S26OC-0002RH-Ex for pgsql-hackers@postgresql.org; Mon, 27 Feb 2012 19:37:41 +0000 Received: from intern.anarazel.de (p57BD7B7C.dip.t-dialin.net [87.189.123.124]) (Authenticated sender: andres@anarazel.de) by mail.anarazel.de (Postfix) with ESMTPA id 72C95448004; Mon, 27 Feb 2012 20:37:26 +0100 (CET) From: Andres Freund To: pgsql-hackers@postgresql.org Subject: Re: Command Triggers, patch v11 Date: Mon, 27 Feb 2012 20:37:24 +0100 User-Agent: KMail/1.13.7 (Linux/3.3.0-rc2-andres-00226-g98e9685; KDE/4.6.5; x86_64; ; ) Cc: Thom Brown , Dimitri Fontaine References: In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201202272037.25322.andres@anarazel.de> X-Pg-Spam-Score: -2.6 (--) X-Archive-Number: 201202/1331 X-Sequence-Number: 203695 On Monday, February 27, 2012 08:30:31 PM Thom Brown wrote: > On 27 February 2012 19:19, Dimitri Fontaine wrote: > > Thom Brown writes: > >> test=# CREATE TABLE badname AS SELECT 1::int id, 1::int a, ''::text b; > >> SELECT 1 > >> > >> This doesn't even get picked up by ANY COMMAND. > > > > You won't believe it: CTAS is not implemented as a DDL. Andres did > > some work about that and sent a patch that received positive reviews by > > both Tom and Robert, once that's in I can easily add support for the > > command. I actually don't think anybody actually reviewed the patch so far. Tom and I discussed the implementation strategy beforehand a bit though. > > Thanks Andres :) Youre welcome. Thanks for your awesome work that actually made it necessary ;) > I don't see it anywhere in the commitfest. Has it been properly submitted? I actually always viewed it as a part of the Dim's patch which is why I didn't submit it as a separate patch. Maybe that was a mistake... http://archives.postgresql.org/message- id/201112112346.07611.andres@anarazel.de contains the latest revision. Andres