Received: from magus.postgresql.org (magus.postgresql.org [87.238.57.229]) by mail.postgresql.org (Postfix) with ESMTP id 4C94015907D for ; Mon, 5 Mar 2012 17:11:16 -0400 (AST) Received: from mail.anarazel.de ([217.115.131.40]) by magus.postgresql.org with esmtp (Exim 4.72) (envelope-from ) id 1S4fBU-0002QO-WF for pgsql-hackers@postgresql.org; Mon, 05 Mar 2012 21:11:15 +0000 Received: from intern.anarazel.de (cpe-98-14-208-248.nyc.res.rr.com [98.14.208.248]) (Authenticated sender: andres@anarazel.de) by mail.anarazel.de (Postfix) with ESMTPA id 6CA0D448005; Mon, 5 Mar 2012 22:10:55 +0100 (CET) From: Andres Freund To: pgsql-hackers@postgresql.org Subject: Re: Command Triggers, patch v11 Date: Mon, 5 Mar 2012 22:10:37 +0100 User-Agent: KMail/1.13.7 (Linux/3.3.0-rc5-andres-00066-g500dd23; KDE/4.6.5; x86_64; ; ) Cc: Dimitri Fontaine , Thom Brown , Tom Lane References: In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201203052210.38024.andres@anarazel.de> X-Pg-Spam-Score: -2.6 (--) X-Archive-Number: 201203/239 X-Sequence-Number: 204121 On Monday, March 05, 2012 09:42:00 PM Dimitri Fontaine wrote: > > Still no command triggers firing for CREATE TABLE AS: > Yes, Andres made CTAS a utility command, he didn't add the code that > make them fire command triggers. I would expect his patch to get in > first, so I don't expect him to be adding that support, I think I will > have to add it when rebasing once his patch has landed. That was my assumption as well. Any opinions about adding the patch to the commitfest other than from dim? I feel a bit bad adding it to the in-progress one even if its belongs there because is a part of the command trigger stuff... Andres