From: Andres Freund <andres@anarazel.de>
To: pgsql-hackers@postgresql.org
Subject: Re: Command Triggers, patch v11
Date: Fri, 16 Mar 2012 22:37:38 +0100
User-Agent: KMail/1.13.7 (Linux/3.3.0-rc3-andres-00278-g4903062; KDE/4.6.5;
	x86_64; ; )
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Thom Brown <thom@linux.com>,
	Dimitri Fontaine <dimitri@2ndquadrant.fr>
References: <m24nufq466.fsf@2ndQuadrant.fr>
	<201203162207.23896.andres@anarazel.de>
	<21494.1331933517@sss.pgh.pa.us>
In-Reply-To: <21494.1331933517@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201203162237.38813.andres@anarazel.de>

On Friday, March 16, 2012 10:31:57 PM Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > One more thing I disliked quite a bit was the duplication of the EXECUTE
> > handling. Do you see a way to deduplicate that?
> Yeah, that's what's bugging me, too.  I think a chunk of the problem is
> that you're insisting on having control come back to CreateTableAs()
> to perform the table creation.  I'm thinking that if the table creation
> were to be moved into the tuple receiver's startup routine, we could
> avoid needing to get control back between ExecutorStartup and
> ExecutorRun, and then all that would be required would be to call
> ExecuteQuery with a different DestReceiver.
Hm. I seriously dislike doing that in the receiver. I can't really point out 
why though. Unsurprisingly I like getting the control back to CreateTableAs...

Andres