Date: Thu, 5 Apr 2012 20:19:07 -0400
From: Noah Misch <noah@leadboat.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Simon Riggs <simon@2ndquadrant.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Last gasp
Message-ID: <20120406001907.GB4451@tornado.leadboat.com>
References: 
 <CA+U5nML0w7FAM8Wi6W1ObSa160ipN5shg3Z0y91ew-Um8iXxCg@mail.gmail.com>
	<CA+TgmoazMq6FF2otE_5HYJr3nwwEy9_0TmGYu_G3AsY8ckQcjg@mail.gmail.com>
	<23175.1333650183@sss.pgh.pa.us>
	<CA+TgmoaVqVCAsyPL3miqeeUOzWM98eBBtOpX9xE_Ft-F62hJLA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CA+TgmoaVqVCAsyPL3miqeeUOzWM98eBBtOpX9xE_Ft-F62hJLA@mail.gmail.com>
User-Agent: Mutt/1.5.18 (2008-05-17)

On Thu, Apr 05, 2012 at 02:34:30PM -0400, Robert Haas wrote:
> On Thu, Apr 5, 2012 at 2:23 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > The FK arrays one I'm kind of queasy about. ?It's a cool-sounding idea
> > but I'm not convinced that all the corner-case details have been
> > adequately thought through, and I'm scared of being unable to fix any
> > such bugs in later versions because of backwards compatibility worries.
> > It'd be a lot better to be pushing this in at the start of a devel cycle
> > than the end.
> 
> I've been feeling that that patch has been suffering from a lack of
> reviewer attention, which is a real shame, because I think the
> functionality is indeed really cool.  But I haven't looked at it
> enough to know what kind of shape it's in.

As the reviewer, I'm not aware of any unexplored corner cases or problems that
ought to preclude commit.  That said, it is a large patch; I doubt anyone
could pick it up from scratch and commit it with less than a solid day's
effort, and 2-3 days might be more likely.  In retrospect, I should have
suggested splitting the new ON DELETE/ON UPDATE actions into their own patch.
That would have nicely slimmed the base patch and also isolated it from the ON
DELETE EACH CASCADE judgement call.