Received: from makus.postgresql.org (makus.postgresql.org [98.129.198.125]) by mail.postgresql.org (Postfix) with ESMTP id 38593B1062A; Sun, 8 Apr 2012 14:39:15 -0300 (ADT) Received: from gauss.credativ.com ([93.94.130.89]) by makus.postgresql.org with esmtp (Exim 4.72) (envelope-from ) id 1SGw53-0006SI-FT; Sun, 08 Apr 2012 17:39:14 +0000 Received: from feivel (p5DC925FC.dip.t-dialin.net [93.201.37.252]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: mme@gauss.credativ.com) by gauss.credativ.com (Postfix) with ESMTPSA id 9F89A55016D; Sun, 8 Apr 2012 19:38:59 +0200 (CEST) Received: by feivel (Postfix, from userid 1000) id 153E59F6D8; Sun, 8 Apr 2012 19:38:59 +0200 (CEST) Date: Sun, 8 Apr 2012 19:38:59 +0200 From: Michael Meskes To: Boszormenyi Zoltan Cc: Noah Misch , Michael Meskes , Robert Haas , PG Hackers , Heikki Linnakangas , Bruce Momjian Subject: Re: ECPG FETCH readahead Message-ID: <20120408173859.GA4915@feivel.credativ.lan> Mail-Followup-To: Boszormenyi Zoltan , Noah Misch , Michael Meskes , Robert Haas , PG Hackers , Heikki Linnakangas , Bruce Momjian References: <4F6D9893.3030300@cybertec.at> <20120329004323.GA17329@tornado.leadboat.com> <4F74409C.3050904@cybertec.at> <20120329170341.GA4142@tornado.leadboat.com> <4F74E6A7.8040204@cybertec.at> <20120407112008.GA2286@feivel.credativ.lan> <20120407155042.GB11987@tornado.leadboat.com> <20120408142501.GA21513@feivel.credativ.lan> <4F81BE55.1010904@cybertec.at> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <4F81BE55.1010904@cybertec.at> User-Agent: Mutt/1.5.21 (2010-09-15) Content-Transfer-Encoding: quoted-printable X-Pg-Spam-Score: -1.9 (-) X-Archive-Number: 201204/359 X-Sequence-Number: 206162 On Sun, Apr 08, 2012 at 06:35:33PM +0200, Boszormenyi Zoltan wrote: > Do you want me to change this or will you do it? I am on holiday > and will be back to work on wednesday. I don't think waiting till later this week is a real problem.=20 > The possibility to test different readahead window sizes > without modifying the source and recompiling was useful. Sure, but you can still do that when not defining a fixed number in the statement. > The -R option simply provides a default without ornamenting > the DECLARE statement. Could you please incorporate these changes, too, when you're back from va= cation? > >I cannot find a test that tests the environment variable giving the fe= tch size. > >Could you please point me to that? >=20 > I didn't write such a test. The reason is that while variables are > exported by make from the Makefile to the binaries run by make > e.g. CFLAGS et.al. for $(CC), "make check" simply runs pg_regress > once which uses its own configuration file that doesn't have a > way to set or unset an environment variable. This could be a useful > extension to pg_regress though. How about calling setenv() from the test program itself?=20 Michael --=20 Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org Jabber: michael.meskes at googlemail dot com VfL Borussia! For=C3=A7a Bar=C3=A7a! Go SF 49ers! Use Debian GNU/Linux, P= ostgreSQL