From: Andres Freund <andres@2ndquadrant.com>
Organization: 2ndquadrant.com
To: pgsql-hackers@postgresql.org
Subject: Re: [RFC][PATCH] Logical Replication/BDR prototype and architecture
Date: Wed, 13 Jun 2012 19:24:29 +0200
User-Agent: KMail/1.13.7 (Linux/3.4.0-andres; KDE/4.8.3; x86_64; ; )
Cc: Steve Singer <steve@ssinger.info>
References: <201206131327.24092.andres@2ndquadrant.com>
	<BLU0-SMTP137E21E664F8F16D711A2DDCF50@phx.gbl>
In-Reply-To: <BLU0-SMTP137E21E664F8F16D711A2DDCF50@phx.gbl>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="windows-1252"
Content-Transfer-Encoding: quoted-printable
Message-Id: <201206131924.30062.andres@2ndquadrant.com>

On Wednesday, June 13, 2012 07:11:40 PM Steve Singer wrote:
> On 12-06-13 07:27 AM, Andres Freund wrote:
> > Its also available in the 'cabal-rebasing' branch on
> > git.postgresql.org/users/andresfreund/postgres.git . That branch will
> > modify history though.
>=20
> That branch has a merge error in f685a11ce43b9694cbe61ffa42e396c9fbc32b05
>=20
>=20
> gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith
> -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute
> -Wformat-security -fno-strict-aliasing -fwrapv -I../../../../src/include
> -D_GNU_SOURCE -c -o xact.o xact.c
> xact.c:4684: error: expected identifier or =91(=92 before =91<<=92 token
> xact.c:4690:46: warning: character constant too long for its type
> xact.c:4712:46: warning: character constant too long for its type
> xact.c:4719: error: expected identifier or =91(=92 before =91<<=92 token
> xact.c:4740:46: warning: character constant too long for its type
> make[4]: *** [xact.o] Error 1
Hrmpf. I reordered the patch series a last time to be more clear and I some=
how=20
didn't notice this. I compiled & tested the now pushed head=20
(7e0340a3bef927f79b3d97a11f94ede4b911560c) and will submit an updated patch=
=20
[10/16].

Andres