Received: from makus.postgresql.org ([98.129.198.125]) by malur.postgresql.org with esmtp (Exim 4.72) (envelope-from ) id 1TYfoL-0005YJ-HD for pgsql-hackers@postgresql.org; Wed, 14 Nov 2012 16:27:33 +0000 Received: from smtprelay0108.b.hostedemail.com ([64.98.42.108] helo=smtprelay.b.hostedemail.com) by makus.postgresql.org with esmtp (Exim 4.72) (envelope-from ) id 1TYfoI-0002GN-Bt for pgsql-hackers@postgresql.org; Wed, 14 Nov 2012 16:27:32 +0000 Received: from filter.hostedemail.com (b-bigip1 [10.5.19.254]) by smtprelay04.b.hostedemail.com (Postfix) with SMTP id 3B4B4B8CD6; Wed, 14 Nov 2012 16:27:29 +0000 (UTC) X-Panda: scanned! X-Spam-Summary: 50, 0, 0, , d41d8cd98f00b204, alvherre@alvh.no-ip.org, :::, RULES_HIT:355:379:599:601:967:973:988:989:1260:1277:1311:1312:1313:1314:1345:1358:1359:1437:1515:1516:1518:1519:1534:1539:1593:1594:1595:1596:1711:1714:1730:1747:1777:1792:2393:2525:2561:2564:2682:2685:2828:2859:2903:2933:2937:2939:2942:2945:2947:2951:2954:3022:3027:3138:3139:3140:3141:3142:3350:3865:3867:3868:3869:3870:3871:3872:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4605:4659:5007:6119:6261:7679:7903:9025:9121:10004:10400:10848:11256:11257:11473:11658:11914:12043:12438:12517:12519:12679, 0, RBL:none, CacheIP:none, Bayesian:0.5, 0.5, 0.5, Netcheck:none, DomainCache:0, MSF:not bulk, SPF:fn, MSBL:0, DNSBL:none, Custom_rules:0:0:0 X-Session-Marker: 616C76686572726540616C76682E6E6F2D69702E6F7267 X-Filterd-Recvd-Size: 1642 Received: from perhan.alvh.no-ip.org (unknown [200.85.208.156]) (Authenticated sender: alvherre@alvh.no-ip.org) by omf10.b.hostedemail.com (Postfix) with ESMTPA; Wed, 14 Nov 2012 16:27:28 +0000 (UTC) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id 845186E034; Wed, 14 Nov 2012 13:27:26 -0300 (CLST) Date: Wed, 14 Nov 2012 13:27:26 -0300 From: Alvaro Herrera To: Andres Freund Cc: pgsql-hackers@postgresql.org Subject: Re: foreign key locks Message-ID: <20121114162726.GE5161@alvh.no-ip.org> References: <4FEAB90A0200002500048B7D@gw.wicourts.gov> <1346389151-sup-8379@alvh.no-ip.org> <20121018195820.GO3763@alvh.no-ip.org> <201210270006.54728.andres@2ndquadrant.com> <20121114152347.GA5161@alvh.no-ip.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20121114152347.GA5161@alvh.no-ip.org> User-Agent: Mutt/1.5.21 (2010-09-15) Content-Transfer-Encoding: quoted-printable X-Pg-Spam-Score: 0.3 (/) X-Archive-Number: 201211/629 X-Sequence-Number: 216481 Alvaro Herrera wrote: > > * In heap_lock_tuple's XMAX_IS_MULTI case > >=20 > > [snip] > >=20 > > why is it membermode > mode and not membermode >=3D mode? >=20 > Uh, that's a bug. Fixed. As noticed in the comment above that snippet= , > there was a deadlock possible here. Maybe I should add a test to ensur= e > this doesn't happen. Done: https://github.com/alvherre/postgres/commit/df2847e38198e99f57e52490e1e93= 91ebb70d770 (I don't think this is worth a v24 submission). --=20 =C1lvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services