Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.72) (envelope-from ) id 1TfYaR-0006Ee-52 for pgsql-hackers@arkaria.postgresql.org; Mon, 03 Dec 2012 16:09:39 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.72) (envelope-from ) id 1TfYaQ-0000iJ-7s for pgsql-hackers@arkaria.postgresql.org; Mon, 03 Dec 2012 16:09:38 +0000 Received: from makus.postgresql.org ([98.129.198.125]) by malur.postgresql.org with esmtp (Exim 4.72) (envelope-from ) id 1TfYaP-0000iD-Fq for pgsql-hackers@postgresql.org; Mon, 03 Dec 2012 16:09:37 +0000 Received: from 173-164-140-181-sfba.hfc.comcastbusiness.net ([173.164.140.181] helo=fetter.org) by makus.postgresql.org with esmtp (Exim 4.72) (envelope-from ) id 1TfYaN-0004SH-Qv for pgsql-hackers@postgresql.org; Mon, 03 Dec 2012 16:09:36 +0000 Received: by fetter.org (Postfix, from userid 500) id 1FB47300E0C; Mon, 3 Dec 2012 08:09:35 -0800 (PST) Date: Mon, 3 Dec 2012 08:09:35 -0800 From: David Fetter To: Simon Riggs Cc: Kohei KaiGai , Robert Haas , Alvaro Herrera , Dean Rasheed , Tom Lane , Florian Pflug , PgHacker Subject: Re: [v9.3] Row-Level Security Message-ID: <20121203160935.GB16951@fetter.org> References: <20121018181956.GL3763@alvh.no-ip.org> <20121203152521.GA16951@fetter.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Pg-Spam-Score: -0.9 (/) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org On Mon, Dec 03, 2012 at 03:41:47PM +0000, Simon Riggs wrote: > On 3 December 2012 15:36, Kohei KaiGai wrote: > > 2012/12/3 David Fetter : > >> On Sun, Nov 25, 2012 at 03:20:28PM +0100, Kohei KaiGai wrote: > >>> > However, UPDATE / DELETE support is not perfect right now. > >>> > In case when we try to update / delete a table with inherited > >>> > children and RETURNING clause was added, is loses right > >>> > references to the pseudo columns, even though it works fine > >>> > without inherited children. > >>> > > >>> The attached patch fixed this known problem. > >> > >> This patch no longer applies to git master. Any chance of a rebase? > >> > > OK, I'll rebese it. > > No chunk failures, its just fuzz. I must have done something wrong. I downloaded the patch from the web email archives, then ran "git apply" on it, and got this: $ git apply ../pgsql-v9.3-row-level-security.rw.v7.patch ../pgsql-v9.3-row-level-security.rw.v7.patch:806: space before tab in indent. * row-level security policy ../pgsql-v9.3-row-level-security.rw.v7.patch:1909: trailing whitespace. * would be given. Because the sub-query has security barrier flag, ../pgsql-v9.3-row-level-security.rw.v7.patch:2886: trailing whitespace. did | cid | dlevel | dauthor | dtitle ../pgsql-v9.3-row-level-security.rw.v7.patch:2899: trailing whitespace. cid | did | dlevel | dauthor | dtitle | cname ../pgsql-v9.3-row-level-security.rw.v7.patch:2918: trailing whitespace. did | cid | dlevel | dauthor | dtitle error: patch failed: src/backend/commands/copy.c:34 error: src/backend/commands/copy.c: patch does not apply What did I do wrong here? Cheers, David. -- David Fetter http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: david.fetter@gmail.com iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics Remember to vote! Consider donating to Postgres: http://www.postgresql.org/about/donate -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers