Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1oEIOt-0003Ug-H4
	for pgsql-hackers@arkaria.postgresql.org; Wed, 20 Jul 2022 22:42:39 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1oEIOr-0003D3-Ah
	for pgsql-hackers@arkaria.postgresql.org; Wed, 20 Jul 2022 22:42:37 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1oEIOq-0003Bu-Vn
	for pgsql-hackers@lists.postgresql.org; Wed, 20 Jul 2022 22:42:36 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1oEIOo-00026M-NF
	for pgsql-hackers@postgresql.org; Wed, 20 Jul 2022 22:42:35 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 26KMgVGb2012343;
	Wed, 20 Jul 2022 18:42:31 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jacob Champion <jchampion@timescale.com>
cc: Andres Freund <andres@anarazel.de>,
        Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Log details for client certificate failures
In-reply-to: 
 <CAAWbhmj3q=RbGwurus5V3Dh7u5q9msVmQ=61mZptoWxBBuWJug@mail.gmail.com>
References: <2878aee8-a4a6-8078-9740-efe90fcf8328@timescale.com>
 <20220715211914.c5oasfknx2njndov@awork3.anarazel.de>
 <1d3d62a0-2d7f-4592-bf76-ba59a77e61cc@timescale.com>
 <20220715234519.7o4mlpxapmqmv6p7@awork3.anarazel.de>
 <CAAWbhmiH2dPpRUnpS6pe9Fge--gj_az4ra2AJO1JvTKeiFuAug@mail.gmail.com>
 <20220719161432.qha3s76vyc6k4v5m@awork3.anarazel.de>
 <c0eca922-59db-ad5c-193f-09bc36b92468@timescale.com>
 <1212792.1658248783@sss.pgh.pa.us>
 <20220719170954.nshvmok3tymxdpl3@awork3.anarazel.de>
 <CAAWbhmiVZgfAUc=BuahotfHokWuJXLD6KQs8gYVvp_twFgQ-xg@mail.gmail.com>
 <20220719223823.pj4z36ce3zb27qdb@alap3.anarazel.de>
 <CAAWbhmhGOh_1C6x1A8K5hsMuSeOF5hxQ4ZMGkFhqmVTZ0otzRQ@mail.gmail.com>
 <2007344.1658355307@sss.pgh.pa.us>
 <CAAWbhmj3q=RbGwurus5V3Dh7u5q9msVmQ=61mZptoWxBBuWJug@mail.gmail.com>
Comments: In-reply-to Jacob Champion <jchampion@timescale.com>
	message dated "Wed, 20 Jul 2022 15:29:55 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2012341.1658356951.1@sss.pgh.pa.us>
Date: Wed, 20 Jul 2022 18:42:31 -0400
Message-ID: <2012342.1658356951@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/2012342.1658356951%40sss.pgh.pa.us>
Precedence: bulk

Jacob Champion <jchampion@timescale.com> writes:
> I'm currently hardcoding an elevel of ERROR on the new guc_strdup()s,
> because that seems to be a common case for the check hooks.

Really?  That's almost certainly NOT okay.  As an example, if you
have a problem with a new value loaded from postgresql.conf during
SIGHUP processing, throwing ERROR will cause the postmaster to exit.

I wouldn't be too surprised if there are isolated cases where people
didn't understand what they were doing and wrote that, but that
needs to be fixed not emulated.

			regards, tom lane